Add in array_join support #11420
Merged
Add in array_join support #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
approved these changes
Sep 3, 2024
ttnghia
reviewed
Sep 4, 2024
| case class GpuArrayJoin(override val children : Seq[Expression]) | ||
| extends GpuExpression with ShimExpression { | ||
|
|
||
| private val array = children(0) |
There was a problem hiding this comment.
Nit: Typically do not use universal keyword as variable name. Instead of array we can use input or array_data or something similar.
There was a problem hiding this comment.
I was just following exactly what Spark did for the naming.
array is technically not a keyword in scala or the code would not compile. It is not even the name of a class in scala. That is Array. But I am really nit picking at this point.
I did it really to match what Spark was doing for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in support for the array_join expression.
This closes #5223
But I will file a follow on issue to deal with rapidsai/cudf#12766 when it is fixed.
Note that this does not handle a null replacement that is not a Scalar. I can add it in without too much work. It is just that I have to special case that even more because there are no CUDF APIs to handle it.