Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add alternate handling for all null list in join_list_elements #12766

Open
karthikeyann opened this issue Feb 13, 2023 · 0 comments
Open

[FEA] Add alternate handling for all null list in join_list_elements #12766

karthikeyann opened this issue Feb 13, 2023 · 0 comments
Assignees
@ttnghia
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Milestone
Joins continuous ...

Comments

@karthikeyann
Copy link
Contributor

karthikeyann commented Feb 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
All null list is considered as empty list as special handling in join_list_elements API.
But this special handling may not be required by all the users.

Describe the solution you'd like
Provide an option to skip this special handling.

Describe alternatives you've considered
Replace all nulls in child columns with "null" before using join_list_elements API. But it incurs extra memory and compute time.

Additional context
#12767 workaround due to this special handling.
@karthikeyann karthikeyann added feature request New feature or request Needs Triage Need team to review and classify labels Feb 13, 2023
@karthikeyann karthikeyann mentioned this issue Feb 13, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Feb 16, 2023
@karthikeyann
Fix bug in all-null list due to join_list_elements special handling (#…
a00295a 
…12767)

All-null list is considered as empty list in `join_list_elements`. So, nulls of children are replaced by `narep` before passing to `join_list_elements` API.
Related #12766

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)

URL: #12767
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment code quality libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Apr 2, 2023
This was referenced Sep 3, 2024
Closed
Merged
@ttnghia ttnghia self-assigned this Sep 3, 2024
@revans2 revans2 mentioned this issue Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttnghia ttnghia

Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
Joins continuous improvement
Development

No branches or pull requests
4 participants
@vyasr @karthikeyann @ttnghia @GregoryKimball