Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update German & Northern Sámi translations + English language template #1424

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

osma
Copy link
Member

@osma osma commented Mar 23, 2023

Reasons for creating this PR

There were more recent translations available on Transifex. I'm updating them to the Skosmos codebase so that they can be used by all Skosmos users.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

Known problems or uncertainties in this PR

The fetch-from-transifex script is no longer working, apparently Transifex changed its URLs. That should probably be reported separately...

Anyway I downloaded all translations as a ZIP file and then renamed the .po files to match Skosmos conventions.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 2.17 milestone Mar 23, 2023
@osma osma self-assigned this Mar 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit a6f1795 into master Mar 23, 2023
@osma osma deleted the update-translations-2023-03 branch March 23, 2023 10:54
@osma
Copy link
Member Author

osma commented Mar 23, 2023

Cherry-picked this update also to the v2.16-maintenance branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

altLabels disappear when browsed in North Sámi
1 participant