-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang6Stdenv, clang-tools_6, clang_6, lld_6, lldb_6, llvm_6: remove #279581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Jan 8, 2024
philiptaron
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one edit requested
trofi
force-pushed
the
clang6Stdenv-and-co-removal
branch
from
January 8, 2024 19:37
f170bc6
to
8a1b665
Compare
Remove all the aliases for `llvmPackages_6` except the `llvmPackages_6` itself. We can remove `llvmPackages_6` once last two users are gone: - vimPlugins: NixOS#279576 - beignet: NixOS#279578
wegank
force-pushed
the
clang6Stdenv-and-co-removal
branch
from
January 9, 2024 21:37
8a1b665
to
edf1196
Compare
Remove as the last two users are gone.
wegank
force-pushed
the
clang6Stdenv-and-co-removal
branch
from
January 9, 2024 21:38
edf1196
to
927f939
Compare
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Jan 9, 2024
sternenseemann
approved these changes
Jan 10, 2024
delroth
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Jan 10, 2024
philiptaron
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
delroth
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Jan 10, 2024
rrbutani
added
the
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
label
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
8.has: clean-up
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 2
This PR was reviewed and approved by two reputable people
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the aliases forllvmPackages_6
except thellvmPackages_6
itself.We can removellvmPackages_6
once last two users are gone:Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.