Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang6Stdenv, clang-tools_6, clang_6, lld_6, lldb_6, llvm_6: remove #279581

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 8, 2024

Remove all the aliases for llvmPackages_6 except the llvmPackages_6 itself.

We can remove llvmPackages_6 once last two users are gone:

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one edit requested

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
@trofi trofi force-pushed the clang6Stdenv-and-co-removal branch from f170bc6 to 8a1b665 Compare January 8, 2024 19:37
Remove all the aliases for `llvmPackages_6` except the `llvmPackages_6`
itself.

We can remove `llvmPackages_6` once last two users are gone:

- vimPlugins: NixOS#279576
- beignet: NixOS#279578
@wegank wegank force-pushed the clang6Stdenv-and-co-removal branch from 8a1b665 to edf1196 Compare January 9, 2024 21:37
Remove as the last two users are gone.
@wegank wegank force-pushed the clang6Stdenv-and-co-removal branch from edf1196 to 927f939 Compare January 9, 2024 21:38
@trofi trofi requested a review from RaitoBezarius as a code owner January 9, 2024 21:38
@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 9, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 10, 2024
@wegank wegank merged commit 0373b68 into NixOS:master Jan 10, 2024
23 checks passed
@trofi trofi deleted the clang6Stdenv-and-co-removal branch January 10, 2024 22:20
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants