-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD15: use current wind instead of extrapolated wind #2181
Merged
andrew-platt
merged 5 commits into
OpenFAST:dev-unstable-pointers
from
andrew-platt:f/AD15_IfW_noExtrap
May 9, 2024
Merged
AD15: use current wind instead of extrapolated wind #2181
andrew-platt
merged 5 commits into
OpenFAST:dev-unstable-pointers
from
andrew-platt:f/AD15_IfW_noExtrap
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-platt
changed the title
F/ad15 if w no extrap
AD15: use current wind instead of extrapolated wind
Apr 30, 2024
bjonkman
reviewed
Apr 30, 2024
Since this PR builds on #2014, it is not clear exactly what the difference is. I posted a temporary PR at andrew-platt#22 which corresponds to this PR after #2014 is merged in. |
Simplification based on comment from @bjonkman
andrew-platt
force-pushed
the
f/AD15_IfW_noExtrap
branch
from
April 30, 2024 21:42
479bd62
to
211dea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for merging.
Feature or improvement description
When InflowWind was converted to use pointers, significant changes were required to AeroDyn to support this with linearization (InflowWind outputs are no longer inputs to AeroDyn). This is the third of 3 PR's to address this.
In this PR, the wind used in AeroDyn uses the wind interpolated from the wind data using the extrapolated position information (from AD15 inputs). Previously the wind was extrapolated from the previous wind inputs (extrapolated like the position information). This is a very subtle change, but affects almost all AD15 cases with turbulent winds.
old method:
new method:
Related issue, if one exists
Impacted areas of the software
Only the AeroDyn module is affected.
Test results, if applicable
Several AeroDyn15 regression tests have changed as a result of using the current wind data instead of extrapolated winds. The observed changes in the regression tests were very small for all cases except the OpenFAST MHK cases. In general very small changes in wind velocity along the blade are observed as the sampling of the wind is now based on the extrapolated blade position (from the last 2 or 3 timesteps) instead of an extrapolation of the wind. This leads to very small differences in wind speed at each blade or tower node, which in turn leads to very small changes blade loads (see sample plots in comments below).
In the MHK cases, the structural response changes due to the change in loading along the blade or tower, but is very close to the original in the first few timesteps. This is expected giving the fluid density in the MHK calculations compared to wind loading for wind turbines.
The following tests require updating:
OpenFAST:
AWT_YFree_WSt
- sheared wind profileAOC_YFree_WTurb
- turbulent windAOC_YFix_WSt
- sheared wind profileWP_VSP_ECD
- gust with direction change, small change in tip flap accelerationsWP_VSP_WTurb
- turbulent wind, IPDefl1 slightly shiftedSWRT_YFree_VS_EDG01
- gust, very tiny shift in rotor azimuth leading to shift in TipClrnc5MW_Land_DLL_WTurb
/5MW_Land_DLL_WTurb_py
- turbulent wind5MW_OC3Mnpl_DLL_WTurb_WavesIrr
/5MW_OC3Mnpl_DLL_WTurb_WavesIrr_Restart
- turbulent wind5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti
/5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti_py
- turbulent wind5MW_OC3Spar_DLL_WTurb_WavesIrr
/5MW_OC3Spar_DLL_WTurb_WavesIrr_py
- turbulent wind5MW_Land_BD_DLL_WTurb
/5MW_Land_BD_DLL_WTurb_py
/5MW_Land_BD_DLL_WTurb_cpp
- turbulent wind, small rotor azimuth driftLinearization:
Fake5MW_AeroLin_B1_UA4_DBEMT3
- very small changes in operating points, identical frequency/dampingFake5MW_AeroLin_B3_UA6
- very small changes in operating points, identical frequency/dampingAeroDyn:
ad_BAR_CombinedCases
- small change inVindx
along the blade leading to small changes inAxInd
and load changesad_BAR_SineMotion
- small wind velocity changes, different loadsad_BAR_SineMotion_UA4_DBEMT3
- smallRtAeroFzh
shift from small shift inHWindSpeedX
MHK:
MHK_RM1_Fixed
- small changes in tower/blade fluid induced moments at simulation start leading to changes in motionMHK_RM1_Floating
- small changes in tower/blade fluid induced moments at simulation start leading to changes in motionad_MHK_RM1_Fixed
- minor differences in calculatedB2FldMx
ad_MHK_RM1_Floating
- shiftedHWindSpeedX
by 1 timestep ???