Merge dev-unstable-pointers branch to dev #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HD: Remove extra copy of `WaveStMod` from Morison
This also includes a change to the NWTC_Library CMakeLists.txt which automatically regenerates NWTC_Library_Types.f90 when Registry_NWTC_Library_base.txt changes
Use int64 to index arrays for Registry pack/unpack routines
- removed readme file that doesn't apply any more - removed SeaSt module dependence from HD (it already uses SeaSt_WaveField)
- I'm not a fan of variables named with lower-case "l", so I made them upper case "L". This is less likely to be confused with the number "1" - registry now gives an error message before ending when data types contain invalid types
in some cases, default reals were used instead of double or single, so the error messages when not able to allocate some variables could have been incorrect
Fix intermittent failure of `system` commands on Windows: occasionally the system calls would fail to finish and make the program hang or end prematurely without any error message.
Use AD tower diameter for VTK visualization + minor improvements
The CMakeLists.txt now automatically generates modules based on the Registry_NWTC_Library_mesh.txt and Registry_NWTC_Library_base.txt files. It also concatenates these files to create the full Registry_NWTC_Library.txt which is included by other modules. The changes to Generate_NWTC_Library_types.bat replicate this behavior.
- add SeaState_Types.f90 - fix case on seastate path name (though it doesn't matter in Windows) - fix NWTC Library registry file name
- NWTC Library registry file was misnamed
More fixes for Visual Studio
New AeroDyn input file exposing new BEM options (polar BEM, skew momentum correction, sector averaging)
There was a bug in how `InitFileInfo` handled a blank line in an input file passed through the c-bindings interface. Fixed it so it matches behaviour from `ProcessComFile`
[BugFix] blank line not handled by InitFileInfo
…AD15_IfW_dataAccess
Remove IfW data from AD15 inputs
…AD15_IfW_Linearization
Linearization with AD15 and IfW
…AD15_IfW_noExtrap
AD15: use current wind instead of extrapolated wind
andrew-platt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
The
dev-unstable-pointersbranch has now been updated with all the necessary linearization fixes, so it can now be merged intodev. Using an intermediate branch for this merge since ther-test/dev-unstable-pointersbranch has some direct commits that might get lost otherwise.Related issue, if one exists
There are a ton of changes on
dev-unstable-pointersthat are not indev. See the following list of PRs for details:General
Build Systems
#2187 VSbuild: Fix syntax errors in Visual Studio project file for AD driver (@bjonkman)
#2189 VSbuild: More fixes for Visual Studio (@bjonkman)
GH actions
#2072 GH actions: update matlab-actions version (@andrew-platt)
#2074 GH actions: remove extraneous "products:" from recipe (added in #2072) (@andrew-platt)
Testing
#2024 Improvements to linearization regression testing (@andrew-platt)
Solvers
FAST.Farm
#1624 Use pointers to couple InflowWind and FAST.Farm (@deslaughter)
Modules
Multiple
#1767 some bug fixes (@bjonkman)
#2078 Minor code cleanup (@bjonkman)
AeroDyn
#1596 Use pointers to couple InflowWind and AeroDyn (@deslaughter)
#1639 InflowWind pointers in AeroDyn, OpenFOAM, and Lidar (@deslaughter)
#1784 Multi-rotor support in ADI c-bindings interface (@andrew-platt)
#1882 Remove IfW data from AD15 inputs (@andrew-platt)
#1909 New AeroDyn input file exposing new BEM options (polar BEM, skew momentum correction, sector averaging) (@ebranlard)
#1973 Use AD tower diameter for VTK visualization + minor improvements (@bjonkman)
#2014 Linearization with AD15 and IfW (@andrew-platt)
#2181 AD15: use current wind instead of extrapolated wind (@andrew-platt)
FAST Registry
#1589 Port openfast-registry to C++ and change pointers (@deslaughter)
#1618 [BugFix] OpenFAST Registry on Windows (@deslaughter)
#1625 Add support for pointers in OpenFAST Registry generated Pack and Unpack subroutines (@deslaughter)
#1919 Use int64 to index arrays for Registry pack/unpack routines (@deslaughter)
#1999 Registry: add flag to allow integers in InputType (@andrew-platt)
HydroDyn
#1609 Use pointers to couple SeaState and HydroDyn (@luwang00)
#1623 Ensure the estimated intersections between the free surface and the Morison members are treated as under water (@luwang00)
#1804 Bug Fix with MSL2SWL (@luwang00)
#1864 Cleanup HydroDyn and SeaState code (@bjonkman)
#1883 HD: Remove extra copy of WaveStMod from Morison (@bjonkman)
#2026 SeaState: combine SeaSt_Interp into SeaSt_WaveField, and bug fix (@andrew-platt)
#2031 HD Bug Fix for ExctnDisp and updates to CTestList.cmake with new r-tests (@luwang00)
#2035 Backward compatibility for the AXIAL COEFFICIENTS section of the HydroDyn input file (@luwang00)
#2069 HD bug fixes to the inertial loads from marine growth and ballast water on strip-theory members (@luwang00)
#2073 HD bug fix to the inertial load from ballast water on strip-theory members (@luwang00)
#2089 HD Bug Fix: Correct the indices of mean drift load components in WAMIT2 (@luwang00)
#2098 More bug fixes in the WAMIT and WAMIT2 modules of HydroDyn with wave headings (@luwang00)
NWTC Lib
#1986 Save registry structures to file without using a buffer (@deslaughter)
#2191 [BugFix] blank line not handled by InitFileInfo (@andrew-platt)
OpenFAST Lib
#2076 Move flag for WriteThisStep to FAST_PreWork (@andrew-platt)
#2186 [Bug] Writing checkpoint files created empty fort.# files (@deslaughter)
SeaState
#1992 SeaState: fix grid size in wave surface visualization (@andrew-platt)
#2071 SeaSt Vis: corrections to PR #1992 (@andrew-platt)
#2113 SeaState: replace pointer attribute with allocatable (@bjonkman)
#2182 Testing: Move test seastate_wavemod5 to after test seastate_wr_kin1 (@andrew-platt)
API changes
#2009 ExtLoads module: Use pointers for wind (@andrew-platt)
#2108 Refactored Aerodyn inflow C binding interface to get blade resolved mesh information (@faisal-bhuiyan)