Release PHPCSExtra 1.0.3 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes `T_STRING` tokens in PHP 8.0+ attributes are either class names or possibly constant names (as a parameter for the class instantiation). They are never function calls. This commit ensures that `T_STRING` tokens in attributes are not confused with function calls. Includes unit test.
…-prevent-false-positive-on-attributes Modernize.FunctionCalls.Dirname: prevent false positives on PHP 8.0+ attributes
The `coverallsapp/github-action` action runner has (finally) created a named branch for the 1.x (and the 2.x) series, so let's use that. Ref: coverallsapp/github-action#100
Grrr.... When PHPUnit has been installed on a high PHP version, some of the dependencies of PHPUnit may now be installed in versions not compatible with PHP 7.4, which would block the install of the Coveralls package. While this is not (yet) a problem in this repo as the max PHPUnit version is set to PHPUnit 7.x, the issue should still be prevented. Installing PHP Coveralls globally instead should fix it. I just wish PHP Coveralls would finally release a version compatible with PHP > 8.0....
…-minor-tweaks GH Actions: various minor tweaks
…-simplify-attributes-fix Modernize.FunctionCalls.Dirname: use PHPCSUtils for attributes fix
To go to the local version of the license instead of an external website.
…e-link README: fix license link
Since Composer 2.2, we can be more specific about which platform requirements should be ignored. This change ensures that only the "high" end of a PHP requirement will be ignored and no other platform requirements are ignored. Ref: https://blog.packagist.com/composer-2-2/#-ignore-platform-req-improvements
As things were, whenever the minimum PHPCS version would be changed, the branch protection settings for both the `stable` and the `develop` branch would need to be updated and all "required builds" referencing the old PHPCS version would need to be removed, while new "required builds" would need to be added referencing the new minimum PHPCS version. This was a fiddly process and time-consuming. The change proposed in this commit takes advantage of the Composer `--prefer-lowest` setting to achieve the same without a hard-coded PHPCS version in the build name, which means that once the branch protection settings have been updated for this PR, they shouldn't need updating anymore for future PHPCS version bumps.
…-tweaks GH Actions: various tweaks
This seemingly small change makes a huge difference in performance for this sniff. On a run of 300+ files, the sniff was more than 7x faster with these tweaks in place. Before: ``` *** START SNIFF PROCESSING REPORT *** PHPCSExtra\Universal\Sniffs\WhiteSpace\DisallowInlineTabsSniff: 0.0022 secs *** END SNIFF PROCESSING REPORT *** ``` After: ``` *** START SNIFF PROCESSING REPORT *** PHPCSExtra\Universal\Sniffs\WhiteSpace\DisallowInlineTabsSniff: 0.0003 secs *** END SNIFF PROCESSING REPORT *** ```
…abs-improve-performance Universal/DisallowInlineTabs: improve sniff performance
* Add a space-based test case file which shouldn't yield any errors or warnings at all. * Make sure that the "tabwidth" set for test files is correctly respected. * Fix the `DisallowInlineTabsUnitTest.5.inc` fixed file.
The `'orig_content'` key only gets set when there are tabs in the token content, so no need for the extra check.
…abs-add-extra-tests Universal/DisallowInlineTabs: add extra tests + remove redundancy
…weaks GH Actions: improve some step descriptions
…classes with attributes
…eanonclassparentheses-add-tests-with-attributes Univeral/[Disallow|Require]AnonClassParentheses: add tests with anon classes with attributes
Changelog for PHPCSExtra 1.0.3
|
Release tweet: https://twitter.com/jrf_nl/status/1640773811418136576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release checklist
General
composer.json- N/A✏️ Remember to add a release link at the bottom!
README(if applicable) - N/ARelease
develop!) & copy & paste the changelog to it.✏️ Check if anything from the link collection at the bottom of the changelog needs to be copied in!
developto be equal tostablePublicize