Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PHPCSExtra 1.0.3 #221

Merged
merged 23 commits into from
Mar 28, 2023
Merged

Release PHPCSExtra 1.0.3 #221

merged 23 commits into from
Mar 28, 2023

Commits on Mar 20, 2023

  1. Modernize.FunctionCalls.Dirname: prevent false positives on PHP 8.0+ …

    …attributes
    
    `T_STRING` tokens in PHP 8.0+ attributes are either class names or possibly constant names (as a parameter for the class instantiation).
    They are never function calls.
    
    This commit ensures that `T_STRING` tokens in attributes are not confused with function calls.
    
    Includes unit test.
    jrfnl committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0317f8d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #211 from PHPCSStandards/feature/modernize-dirname…

    …-prevent-false-positive-on-attributes
    
    Modernize.FunctionCalls.Dirname: prevent false positives on PHP 8.0+ attributes
    jrfnl authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    643b294 View commit details
    Browse the repository at this point in the history
  3. GH Actions: used a named branch for coverallsapp

    The `coverallsapp/github-action` action runner has (finally) created a named branch for the 1.x (and the 2.x) series, so let's use that.
    
    Ref: coverallsapp/github-action#100
    jrfnl committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d883bc1 View commit details
    Browse the repository at this point in the history
  4. GH Actions: fix CI

    Grrr....
    
    When PHPUnit has been installed on a high PHP version, some of the dependencies of PHPUnit may now be installed in versions not compatible with PHP 7.4, which would block the install of the Coveralls package.
    
    While this is not (yet) a problem in this repo as the max PHPUnit version is set to PHPUnit 7.x, the issue should still be prevented.
    
    Installing PHP Coveralls globally instead should fix it.
    
    I just wish PHP Coveralls would finally release a version compatible with PHP >  8.0....
    jrfnl committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    54faa03 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #212 from PHPCSStandards/feature/ghactions-various…

    …-minor-tweaks
    
    GH Actions: various minor tweaks
    jrfnl authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    852240b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Configuration menu
    Copy the full SHA
    52eb4cd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #213 from PHPCSStandards/feature/modernize-dirname…

    …-simplify-attributes-fix
    
    Modernize.FunctionCalls.Dirname: use PHPCSUtils for attributes fix
    jrfnl authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    87e5c0a View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. README: fix license link

    To go to the local version of the license instead of an external website.
    jrfnl committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1ff6b42 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #215 from PHPCSStandards/feature/readme-fix-licens…

    …e-link
    
    README: fix license link
    jrfnl authored Mar 24, 2023
    Configuration menu
    Copy the full SHA
    59818ac View commit details
    Browse the repository at this point in the history
  3. GH Actions: minor tweak to composer install

    Since Composer 2.2, we can be more specific about which platform requirements should be ignored.
    
    This change ensures that only the "high" end of a PHP requirement will be ignored and no other platform requirements are ignored.
    
    Ref: https://blog.packagist.com/composer-2-2/#-ignore-platform-req-improvements
    jrfnl committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2a1c569 View commit details
    Browse the repository at this point in the history
  4. GH Actions: tweak the way the PHPCS versions are set

    As things were, whenever the minimum PHPCS version would be changed, the branch protection settings for both the `stable` and the `develop` branch would need to be updated and all "required builds" referencing the old PHPCS version would need to be removed, while new "required builds" would need to be added referencing the new minimum PHPCS version.
    
    This was a fiddly process and time-consuming.
    
    The change proposed in this commit takes advantage of the Composer `--prefer-lowest` setting to achieve the same without a hard-coded PHPCS version in the build name, which means that once the branch protection settings have been updated for this PR, they shouldn't need updating anymore for future PHPCS version bumps.
    jrfnl committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6dedf63 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #214 from PHPCSStandards/feature/ghactions-various…

    …-tweaks
    
    GH Actions: various tweaks
    jrfnl authored Mar 24, 2023
    Configuration menu
    Copy the full SHA
    398cb7a View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Universal/DisallowInlineTabs: improve sniff performance

    This seemingly small change makes a huge difference in performance for this sniff.
    
    On a run of 300+ files, the sniff was more than 7x faster with these tweaks in place.
    
    Before:
    ```
    *** START SNIFF PROCESSING REPORT ***
    PHPCSExtra\Universal\Sniffs\WhiteSpace\DisallowInlineTabsSniff: 0.0022 secs
    *** END SNIFF PROCESSING REPORT ***
    ```
    
    After:
    ```
    *** START SNIFF PROCESSING REPORT ***
    PHPCSExtra\Universal\Sniffs\WhiteSpace\DisallowInlineTabsSniff: 0.0003 secs
    *** END SNIFF PROCESSING REPORT ***
    ```
    jrfnl committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    7d15218 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #216 from PHPCSStandards/universal/disallowinlinet…

    …abs-improve-performance
    
    Universal/DisallowInlineTabs: improve sniff performance
    jrfnl authored Mar 25, 2023
    Configuration menu
    Copy the full SHA
    5226c51 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2023

  1. Universal/DisallowInlineTabs: add extra tests + fix test tab handling

    * Add a space-based test case file which shouldn't yield any errors or warnings at all.
    * Make sure that the "tabwidth" set for test files is correctly respected.
    * Fix the `DisallowInlineTabsUnitTest.5.inc` fixed file.
    jrfnl committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    19bc003 View commit details
    Browse the repository at this point in the history
  2. Universal/DisallowInlineTabs: remove some redundant code

    The `'orig_content'` key only gets set when there are tabs in the token content, so no need for the extra check.
    jrfnl committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    de1e487 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #217 from PHPCSStandards/universal/disallowinlinet…

    …abs-add-extra-tests
    
    Universal/DisallowInlineTabs: add extra tests + remove redundancy
    jrfnl authored Mar 26, 2023
    Configuration menu
    Copy the full SHA
    75c6ef9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d3491d9 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #218 from PHPCSStandards/feature/ghactions-minor-t…

    …weaks
    
    GH Actions: improve some step descriptions
    jrfnl authored Mar 26, 2023
    Configuration menu
    Copy the full SHA
    1f438a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Univeral/[Disallow|Require]AnonClassParentheses: add tests with anon …

    …classes with attributes
    jrfnl committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f7ad0f3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #219 from PHPCSStandards/universal/disallow-requir…

    …eanonclassparentheses-add-tests-with-attributes
    
    Univeral/[Disallow|Require]AnonClassParentheses: add tests with anon classes with attributes
    jrfnl authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d2adbf9 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Changelog for PHPCSExtra 1.0.3

    jrfnl committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    d7e490b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #220 from PHPCSStandards/feature/changelog-1.0.3

    Changelog for PHPCSExtra 1.0.3
    jrfnl authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    cdf5de5 View commit details
    Browse the repository at this point in the history