Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROS2 Humble for the microRTPS bridge #20968

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

Ecuashungo
Copy link

Solved Problem

ROS2 Humble was not supported when using the mircoRTPS bridge to do offboard control

Fixes #{Github issue ID}

Solution

@dagar
Copy link
Member

dagar commented Jan 22, 2023

Generally we only backport critical bug fixes to point releases (after fixing them in main), but in this case main doesn't even have the microRTPS bridge anymore.

Can you strip this down to nothing more than adding 'humble' and I'll do a v1.13.3 release?

@Ecuashungo
Copy link
Author

Ecuashungo commented Jan 23, 2023

@dagar I have cleaned it up to adding just humble, sorry for the initial commit which was not clean. This can be squashed into 1 commit before the merge, right?
@Jaeyoung-Lim Thanks for the review!

@dagar dagar merged commit 2295ee9 into PX4:release/1.13 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants