Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] px4_fmu-v6c:Add Mini & fix Rev 1 #21227

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Mar 1, 2023

No description provided.

@davids5 davids5 requested a review from mrpollo March 1, 2023 16:41
@davids5
Copy link
Member Author

davids5 commented Mar 1, 2023

@mrpollo @vincentpoont2 will test this in the AM tomorrow. Then it can be merged

@vincentpoont2
Copy link
Contributor

Tested on

  • Pixhawk 6C (VER0 REV 0)
  • Pixhawk 6C (VER0 REV 1)
  • Pixhawk 6C Mini (VER2, REV1)

The sensor calibration, receiver, and LOG functions are all normal

Boot Logs
6c-mini_boot-print.txt
Pixhawk 6C_REV0_20230301 release1.13-pr-backport-HB-6C-Mini0.txt
Pixhawk 6C_REV1_20230301 release1.13-pr-backport-HB-6C-Mini0.txt

@junwoo091400
Copy link
Contributor

junwoo091400 commented Mar 3, 2023

@davids5 note, if you create a branch in release/* format, it automatically triggers the metadata deployment to S3 webserver:

Therefore, it will modify the target metadata before even it gets merged. Could you not use the release/* format for the branch name?

Note: left a comment in discord as well: https://discord.com/channels/1022170275984457759/1045343300850290778/1081108778956619847

@davids5
Copy link
Member Author

davids5 commented Mar 3, 2023

@davids5 note, if you create a branch in release/* format, it automatically triggers the metadata deployment to S3 webserver:

Therefore, it will modify the target metadata before even it gets merged. Could you not use the release/* format for the branch name?

Note: left a comment in discord as well: https://discord.com/channels/1022170275984457759/1045343300850290778/1081108778956619847

@junwoo091400 Good to know - thank you. with the exception of main I use the base name in my branches to keep rebasing and PR on the correct target. I am curious how others keep it straight. How do you do it.

@mrpollo mrpollo merged commit 1c8ab2a into release/1.13 Mar 6, 2023
@mrpollo
Copy link
Contributor

mrpollo commented Mar 6, 2023

Thanks @davids5

@dagar dagar deleted the release/1.13-pr-backport-HB-6C-Mini branch October 19, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants