Fix RC calibration with inverted throttle

[abarcis]

Solved Problem

RC calibration with the inverted throttle leads to wrong values being sent and eventually prevents arming of the vehicle.

Fixes #21575

[junwoo091400]

@abarcis this PR is almost the same as this PR: #21542

[junwoo091400]

Nice catch! Could you rebase to main branch to make sure the CI passes?

Also, would be nice to get a quick review from @MaEtUgR cuz this was introduced from your PR 🙏

[DronecodeBot]

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-maintainers-call-may-23-2023/32245/1

[abarcis]

Nice catch! Could you rebase to main branch to make sure the CI passes?

Also, would be nice to get a quick review from @MaEtUgR cuz this was introduced from your PR pray

Thanks! I've rebased to main but it looks like some checks still did not pass. Is it expected?

[junwoo091400]

Yes, tailistter VTOL SITL and MacOS CIs are expected to fail!

[MaEtUgR]

_parameters.rev[throttle_channel] is a boolean value and gets implicitly cast to an unsigned integer in this pr which of course works without warning in C. Also I'd explicitly split the cases of non-reversed && trim == min; reversed && trim == max. Sorry for the delay, I didn't understand it immediately 😇
My suggestion is this one: #21682

[junwoo091400]

Thanks for this PR @abarcis!

We will continue with this PR: #21682, since it cleans up the logic further. Let me know if you have any comments!