-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned the Event Management's Dashboard tab for the talawa admin portal #1806
Redesigned the Event Management's Dashboard tab for the talawa admin portal #1806
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@palisadoes I am not able to manually link the PR back to this project. Maybe I need certain permissions to the repo. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1806 +/- ##
========================================
Coverage 96.78% 96.79%
========================================
Files 198 198
Lines 4882 4896 +14
Branches 1403 1404 +1
========================================
+ Hits 4725 4739 +14
Misses 150 150
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Please add the missing tabs. We need them as place holders. Use a component methodology of possible |
Isn't the tabs supposed to be implemented in this issue? |
OK. Thanks for the reminder |
0a6b46d
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
A redesign.
Issue Number:
Fixes #1749
Did you add tests for your changes?
No.
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
In the following PR, I have redesigned the Event's dashboard screen for the talawa admin portal according to the figma file here
Does this PR introduce a breaking change?
No.
Other information
Have you read the contributing guide?
Yes.