Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned the Event Management's Dashboard tab for the talawa admin portal #1806

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Sahi1l-Kumar
Copy link

What kind of change does this PR introduce?
A redesign.

Issue Number:
Fixes #1749

Did you add tests for your changes?
No.

Snapshots/Videos:

image

If relevant, did you update the documentation?

Summary
In the following PR, I have redesigned the Event's dashboard screen for the talawa admin portal according to the figma file here

Does this PR introduce a breaking change?
No.

Other information

Have you read the contributing guide?
Yes.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Sahi1l-Kumar
Copy link
Author

Sahi1l-Kumar commented Mar 26, 2024

@palisadoes I am not able to manually link the PR back to this project. Maybe I need certain permissions to the repo.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (971e20a) to head (00dc50d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1806   +/-   ##
========================================
  Coverage    96.78%   96.79%           
========================================
  Files          198      198           
  Lines         4882     4896   +14     
  Branches      1403     1404    +1     
========================================
+ Hits          4725     4739   +14     
  Misses         150      150           
  Partials         7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

Please add the missing tabs. We need them as place holders. Use a component methodology of possible

@Sahi1l-Kumar
Copy link
Author

Please add the missing tabs. We need them as place holders. Use a component methodology of possible

Isn't the tabs supposed to be implemented in this issue?
#1748

@palisadoes
Copy link
Contributor

OK. Thanks for the reminder

@palisadoes palisadoes merged commit 0a6b46d into PalisadoesFoundation:develop Mar 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants