-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Translation] Organisation related pages #2029
[Translation] Organisation related pages #2029
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
WalkthroughThe recent changes primarily focus on enhancing the translation and localization capabilities of the application. Updates were made to various JSON files for multiple languages (English, French, Hindi, Spanish, and Chinese) to include new key-value pairs for common terms and actions. Additionally, several components and screens were modified to utilize these translations dynamically, improving the user experience across different languages. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range and nitpick comments (25)
src/screens/OrganizationActionItems/ActionItemCreateModal.tsx (2)
Line range hint
82-82
: Avoid using array indices as keys in React lists to prevent potential issues with component state and re-rendering.- <option key={index} value={category._id}> + <option key={category._id} value={category._id}>Also applies to: 103-103
Line range hint
60-60
: JSX elements without children should be self-closing to follow best practices.- <i className="fa fa-times"></i> + <i className="fa fa-times" />src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx (2)
Line range hint
82-82
: Avoid using array indices as keys in React lists to prevent potential issues with component state and re-rendering.- <option key={index} value={member._id}> + <option key={member._id} value={member._id}>
Line range hint
61-61
: JSX elements without children should be self-closing to follow best practices.- <i className="fa fa-times"></i> + <i className="fa fa-times" />src/screens/OrganizationVenues/OrganizationVenues.tsx (3)
Line range hint
102-102
: Consider using optional chaining for safer access to nested properties.- if (venueData && venueData.getVenueByOrgId) { + if (venueData?.getVenueByOrgId) {Tools
Biome
[error] 115-115: Template literals are preferred over string concatenation.
Line range hint
203-203
: JSX elements without children should be self-closing to follow best practices.- <Loader /> + <Loader />Tools
Biome
[error] 115-115: Template literals are preferred over string concatenation.
Line range hint
227-227
: Avoid using array indices as keys in React lists to prevent potential issues with component state and re-rendering.- <VenueCard key={index} ... /> + <VenueCard key={venueItem._id} ... />Tools
Biome
[error] 115-115: Template literals are preferred over string concatenation.
src/screens/OrganizationActionItems/OrganizationActionItems.tsx (3)
Line range hint
263-263
: Avoid using array indices as keys in React lists to prevent potential issues with component state and re-rendering.- <Dropdown.Item key={index} ... /> + <Dropdown.Item key={category._id} ... />
Line range hint
320-327
: Ensure accessibility by adding keyboard event handlers for interactive elements.- <i className={`${styles.removeFilterIcon} fa fa-times ms-2 text-body-tertiary pe-auto`} onClick={() => { ... }} /> + <i className={`${styles.removeFilterIcon} fa fa-times ms-2 text-body-tertiary pe-auto`} onClick={() => { ... }} onKeyUp={(e) => { if (e.key === 'Enter') { ... } }} />Also applies to: 334-338
Line range hint
349-349
: JSX elements without children should be self-closing to follow best practices.- <hr /> + <hr />src/screens/OrganizationPeople/OrganizationPeople.tsx (5)
Line range hint
213-213
: Use template literals for better readability and maintainability.- return params.row?.firstName + ' ' + params.row?.lastName; + return `${params.row?.firstName} ${params.row?.lastName}`;
Line range hint
315-315
: Use strict equality checks (===
) instead of loose equality (==
) to avoid type coercion errors.- defaultChecked={state == 2 ? true : false} + defaultChecked={state === 2}Also applies to: 330-330, 343-343, 359-359, 360-360, 361-361
Line range hint
354-354
: JSX elements without children should be self-closing to follow best practices.- <Stack height="100%" alignItems="center" justifyContent="center"> + <Stack height="100%" alignItems="center" justifyContent="center" />
Line range hint
447-456
: Prefer usingfor...of
instead offorEach
for better performance and readability.- original.users.forEach((item) => { + for (const item of original.users) {
Line range hint
104-104
: Specify all dependencies in useEffect to ensure correct re-fetching behavior.- }, [state, adminData]); + }, [state, adminData, adminRefetch, filterData, usersRefetch, currentUrl, memberRefetch]);src/screens/OrganizationFunds/OrganizationFunds.tsx (5)
Line range hint
87-87
: Specify a more precise type instead of 'any' for better type safety.- refetch: any; + refetch: (variables: { organizationId: string; filter?: string }) => void;
Line range hint
165-177
: Replace '!=' with '!==' to avoid type coercion and ensure strict equality checks.- if (formState.fundName != fund?.name) { + if (formState.fundName !== fund?.name) { - if (formState.fundRef != fund?.refrenceNumber) { + if (formState.fundRef !== fund?.refrenceNumber) { - if (taxDeductible != fund?.taxDeductible) { + if (taxDeductible !== fund?.taxDeductible) { - if (isArchived != fund?.isArchived) { + if (isArchived !== fund?.isArchived) { - if (isDefault != fund?.isDefault) { + if (isDefault !== fund?.isDefault) {
Line range hint
260-260
: Simplify the expression by removing unnecessary template literals.- <input placeholder={t('searchBy') + ' ' + tCommon(searchBy)} /> + <input placeholder={`${t('searchBy')} ${tCommon(searchBy)}`} />
Line range hint
219-219
: Use primitive type 'string' instead of 'String' to avoid issues with JavaScript's type system.- handleClick(fundId: String) { + handleClick(fundId: string) {
Line range hint
164-164
: Specify a more precise type instead of 'any' for better type safety.- const [createFund] = useMutation(CREATE_FUND_MUTATION); + const [createFund] = useMutation<CreateFundMutationType>(CREATE_FUND_MUTATION); - const [deleteFund] = useMutation(REMOVE_FUND_MUTATION); + const [deleteFund] = useMutation<DeleteFundMutationType>(REMOVE_FUND_MUTATION);Also applies to: 326-326
src/components/EventManagement/EventActionItems/EventActionItems.tsx (5)
Line range hint
216-218
: Prefer template literals over string concatenation.- {params.row?.assignee.firstName + ' ' + params.row?.assignee.lastName} + `${params.row?.assignee.firstName} ${params.row?.assignee.lastName}`Using template literals here will make the code cleaner and more readable.
Line range hint
310-310
: Ensure JSX elements without children are self-closing.- <br></br> + <br />For JSX elements that do not have children, it's a good practice to use self-closing tags. This makes the code cleaner and more consistent with JSX standards.
Also applies to: 407-407, 467-467, 491-491
Line range hint
516-516
: Avoid unnecessary template literals.- {`${styles.datebox}`} + {styles.datebox}When there is no dynamic computation or variable interpolation, prefer using the variable directly instead of wrapping it in a template literal.
Also applies to: 524-524
Line range hint
143-143
: Specify all dependencies in useEffect.- }, []); + }, [eventId, actionItemsRefetch]);The
useEffect
hook should specify all its dependencies to avoid bugs related to stale closures and ensure the hook runs only when its dependencies change.
Line range hint
332-332
: Avoid using array index as key in React lists.Using array indices as keys in React can lead to issues with component state and performance, especially with lists that can change. Use unique, stable identifiers instead.
Also applies to: 352-352, 428-428
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (18)
- public/locales/en/common.json (2 hunks)
- public/locales/en/translation.json (3 hunks)
- public/locales/fr/common.json (2 hunks)
- public/locales/fr/translation.json (3 hunks)
- public/locales/hi/common.json (2 hunks)
- public/locales/hi/translation.json (3 hunks)
- public/locales/sp/common.json (2 hunks)
- public/locales/sp/translation.json (3 hunks)
- public/locales/zh/common.json (2 hunks)
- public/locales/zh/translation.json (3 hunks)
- src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.tsx (2 hunks)
- src/components/EventManagement/EventActionItems/EventActionItems.tsx (1 hunks)
- src/screens/OrganizationActionItems/ActionItemCreateModal.tsx (1 hunks)
- src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx (1 hunks)
- src/screens/OrganizationActionItems/OrganizationActionItems.tsx (1 hunks)
- src/screens/OrganizationFunds/OrganizationFunds.tsx (1 hunks)
- src/screens/OrganizationPeople/OrganizationPeople.tsx (6 hunks)
- src/screens/OrganizationVenues/OrganizationVenues.tsx (1 hunks)
Additional context used
Biome
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.tsx
[error] 42-42: Avoid using the index of an array as key property in an element.
src/screens/OrganizationActionItems/ActionItemCreateModal.tsx
[error] 60-60: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 1-1: All these imports are only used as types.
[error] 82-82: Avoid using the index of an array as key property in an element.
[error] 103-103: Avoid using the index of an array as key property in an element.
src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx
[error] 61-61: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 1-1: All these imports are only used as types.
[error] 82-82: Avoid using the index of an array as key property in an element.
src/screens/OrganizationVenues/OrganizationVenues.tsx
[error] 102-102: Change to an optional chain.
[error] 115-115: Template literals are preferred over string concatenation.
[error] 124-124: Do not use template literals if interpolation and special-character handling are not needed.
[error] 203-203: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 243-243: Unnecessary use of boolean literals in conditional expression.
[error] 1-1: The default import is only used as a type.
[error] 227-227: Avoid using the index of an array as key property in an element.
src/screens/OrganizationActionItems/OrganizationActionItems.tsx
[error] 94-94: Unnecessary use of boolean literals in conditional expression.
[error] 95-95: Unnecessary use of boolean literals in conditional expression.
[error] 203-203: Do not use template literals if interpolation and special-character handling are not needed.
[error] 320-327: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.
[error] 334-338: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.
[error] 349-349: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 367-367: Do not use template literals if interpolation and special-character handling are not needed.
[error] 263-263: Avoid using the index of an array as key property in an element.
src/screens/OrganizationPeople/OrganizationPeople.tsx
[error] 213-213: Template literals are preferred over string concatenation.
[error] 289-289: Do not use template literals if interpolation and special-character handling are not needed.
[error] 315-315: Unnecessary use of boolean literals in conditional expression.
[error] 315-315: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 330-330: Unnecessary use of boolean literals in conditional expression.
[error] 330-330: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 343-343: Unnecessary use of boolean literals in conditional expression.
[error] 343-343: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 354-354: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 359-359: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 360-360: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 361-361: Use === instead of ==.
== is only allowed when comparing againstnull
[error] 447-456: Prefer for...of instead of forEach.
[error] 104-104: This hook does not specify all of its dependencies: adminRefetch
[error] 104-104: This hook does not specify all of its dependencies: filterData
[error] 104-104: This hook does not specify all of its dependencies: usersRefetch
[error] 104-104: This hook does not specify all of its dependencies: currentUrl
[error] 104-104: This hook does not specify all of its dependencies: memberRefetch
src/screens/OrganizationFunds/OrganizationFunds.tsx
[error] 87-87: Unexpected any. Specify a different type.
[error] 164-164: Unexpected any. Specify a different type.
[error] 165-165: Use !== instead of !=.
!= is only allowed when comparing againstnull
[error] 168-168: Use !== instead of !=.
!= is only allowed when comparing againstnull
[error] 171-171: Use !== instead of !=.
!= is only allowed when comparing againstnull
[error] 174-174: Use !== instead of !=.
!= is only allowed when comparing againstnull
[error] 177-177: Use !== instead of !=.
!= is only allowed when comparing againstnull
[error] 260-260: Do not use template literals if interpolation and special-character handling are not needed.
[error] 326-326: Unexpected any. Specify a different type.
[error] 219-219: Don't use 'String' as a type.
src/components/EventManagement/EventActionItems/EventActionItems.tsx
[error] 216-218: Template literals are preferred over string concatenation.
[error] 310-310: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 407-407: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 467-467: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 491-491: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
[error] 516-516: Do not use template literals if interpolation and special-character handling are not needed.
[error] 524-524: Do not use template literals if interpolation and special-character handling are not needed.
[error] 143-143: This hook does not specify all of its dependencies: actionItemsRefetch
[error] 143-143: This hook does not specify all of its dependencies: eventId
[error] 332-332: Avoid using the index of an array as key property in an element.
[error] 352-352: Avoid using the index of an array as key property in an element.
[error] 428-428: Avoid using the index of an array as key property in an element.
Additional comments not posted (28)
public/locales/zh/common.json (1)
39-39
: Translations added correctly for the Chinese locale.Also applies to: 74-79
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.tsx (1)
6-6
: Correct integration ofuseTranslation
hook to support internationalization.Also applies to: 22-25
public/locales/en/common.json (1)
39-39
: Translations added correctly for the English locale.Also applies to: 74-79
public/locales/sp/common.json (1)
39-39
: Translations added correctly for the Spanish locale.Also applies to: 74-79
public/locales/hi/common.json (1)
39-39
: Translations added correctly for the Hindi locale.Also applies to: 74-79
public/locales/fr/common.json (1)
39-39
: Translations added correctly for the French locale.Also applies to: 74-79
src/screens/OrganizationActionItems/ActionItemCreateModal.tsx (1)
90-90
: Ensure dynamic translation for 'assignee' label is correctly implemented.src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx (1)
67-67
: Ensure dynamic translation for 'assignee' label is correctly implemented.src/screens/OrganizationActionItems/OrganizationActionItems.tsx (1)
313-313
: Ensure dynamic translation for 'noFiltersApplied' is correctly implemented.src/screens/OrganizationPeople/OrganizationPeople.tsx (1)
175-175
: Ensure dynamic translation for table headers and buttons is correctly implemented.Also applies to: 199-199, 220-220, 230-230, 243-243, 256-256, 263-263
src/screens/OrganizationFunds/OrganizationFunds.tsx (1)
374-374
: Translation function correctly implemented for the "Manage" button.src/components/EventManagement/EventActionItems/EventActionItems.tsx (1)
339-339
: Use translation function for dynamic labels.The use of the translation function
{t('assignee')}
for the label in the form is consistent with the PR's objectives to enhance localization. Good job on implementing dynamic translations to improve user experience across different locales.public/locales/zh/translation.json (3)
261-261
: Ensure the translation for "createActionItem" aligns with the intended action in the context of the application.Verification successful
The translation for "createActionItem" aligns with the intended action in the application, as it is used in contexts related to creating action items.
src/screens/OrganizationActionItems/OrganizationActionItems.tsx
src/screens/OrganizationActionItems/OrganizationActionItems.test.tsx
src/screens/OrganizationActionItems/OrganizationActionItemMocks.ts
src/screens/OrganizationActionItems/ActionItemCreateModal.tsx
src/components/OrgActionItemCategories/OrgActionItemCategoryMocks.ts
src/components/OrgActionItemCategories/OrgActionItemCategories.tsx
src/components/ActionItems/ActionItemsModalBody.tsx
src/components/ActionItems/ActionItemsModal.test.tsx
src/components/EventManagement/EventActionItems/EventActionItems.test.tsx
src/components/EventManagement/EventActionItems/EventActionItems.tsx
src/GraphQl/Mutations/ActionItemCategoryMutations.ts
src/GraphQl/Mutations/ActionItemMutations.ts
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" in the application to ensure it aligns with the translation provided. # Test: Search for the key usage in TypeScript files. Expect: Consistent usage that matches the translation context. rg --type ts 'createActionItem'Length of output: 6456
823-827
: The translations for field types ("String", "Boolean", "Date", "Number") are crucial for consistency across the application. Ensure these are used correctly in the context of form inputs or data display.
575-575
: Confirm that the translation for "search" is appropriately used across different contexts in the application.public/locales/en/translation.json (3)
258-258
: Added new key-value pair for "Create Action Items" aligns with the PR's objective to enhance translation support for action items.
570-570
: The addition of the "Search" key in the "addOnStore" section is crucial for improving the search functionality's localization. This change is consistent with the PR's goals to enhance user interface translations.
816-820
: The addition of field types ("String", "Boolean", "Date", "Number") under "orgProfileField" is a significant improvement for dynamic form handling in different locales. This supports the PR's aim to provide better localization across the platform.public/locales/hi/translation.json (3)
261-261
: Ensure the translation for "createActionItem" is consistent with the context and usage across the application.Verification successful
The translation key "createActionItem" is used consistently across the application, including in various test files and components. The translation "कार्रवाई आइटम बनाएं" appears to be correctly integrated.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type typescript --type typescript.tsx 'createActionItem'Length of output: 108
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Test: Search for the translation key usage. Expect: Consistent usage across the application. rg --type json --type ts --type tsx 'createActionItem'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of "createActionItem" across the application to ensure consistency. # Find all relevant files (json, ts, tsx) and search for the translation key usage within those files. fd -e json -e ts -e tsx -x rg 'createActionItem' {}Length of output: 3452
823-827
: Translations for field types ("String", "Boolean", "Date", "Number") are added. Ensure these are used consistently in the UI where field types are displayed or selected.
575-575
: Confirm that the translation for "search" is appropriately used in contexts that involve user input for searching.public/locales/fr/translation.json (3)
261-261
: Added new translation key "createActionItem" with the value "Créer un élément d'action".This addition aligns with the PR's objective to enhance translation coverage across the application.
575-575
: Added new translation key "search" with the value "Rechercher".This is a crucial addition for improving user interface localization, particularly for search functionalities.
823-827
: Added new translation keys for custom field types: "String", "Boolean", "Date", and "Number".These additions are essential for the dynamic translation of custom field types in the application, enhancing the flexibility and localization of the interface.
public/locales/sp/translation.json (4)
375-375
: Added new translation key "createActionItem" for "Crear ítem de acción".This addition aligns with the PR's objective to enhance translation coverage across the application.
756-756
: Added new translation key "search" for "Buscar".This is a necessary addition to support the search functionality in Spanish, improving user experience for Spanish-speaking users.
763-763
: Added new translation key "filter" for "filtros".This addition is crucial for filtering functionalities in Spanish, ensuring consistency and usability for Spanish-speaking users.
1047-1051
: Added new translation keys for field types: "String", "Boolean", "Date", "Number".These additions are essential for the dynamic handling of field types in different languages, enhancing the application's internationalization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.test.tsx (1)
Line range hint
30-32
: Remove unnecessary block statement.- const setCustomFieldData: Dispatch< - SetStateAction<InterfaceCustomFieldData> - > = (val) => { - { - val; - } - }; + const setCustomFieldData: Dispatch< + SetStateAction<InterfaceCustomFieldData> + > = (val) => val;This simplifies the function and removes redundant braces that do not contribute to functionality.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.test.tsx (2 hunks)
Additional context used
Biome
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.test.tsx
[error] 30-32: This block statement doesn't serve any purpose and can be safely removed.
Additional comments not posted (2)
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.test.tsx (2)
9-10
: Integration ofI18nextProvider
andi18nForTest
for internationalization in tests.This change ensures that the component's internationalization functionality can be properly tested, aligning with the changes made in the component itself.
44-46
: Proper use ofI18nextProvider
to wrap theEditOrgCustomFieldDropDown
component in tests.This setup is essential for ensuring that the component behaves as expected under different locales, which is critical given the internationalization focus of the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2029 +/- ##
========================================
Coverage 98.39% 98.39%
========================================
Files 210 210
Lines 5806 5807 +1
Branches 1718 1712 -6
========================================
+ Hits 5713 5714 +1
Misses 87 87
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Note
All Translations for Organisation screens are done! - (SuperAdmin/Admin Logged In)
What kind of change does this PR introduce?
Translation fixes
Issue Number:
Fixes #2028
Did you add tests for your changes?
NA
Snapshots/Videos:
--
2) Venues screen
--
3) Action Item - "No filters"
--
4) Create Button
--
5) "Assignee" on create and edit modal both
--
6) "Manage" button on funds screen
--
7) Search label on AddOnStore
--
8) Custom field dropdown in Org Settings
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Bug Fixes
Tests
I18nextProvider
for handling translations in theEditCustomFieldDropDown
component.Refactor
useTranslation
hook for managing translations in various components, ensuring text elements are dynamically translated based on locale settings.