Fixes multiple add members screen layout issues #2232 #2254
Conversation
WalkthroughThis pull request introduces enhancements to the localization support within the application by adding new translations for user-related fields in multiple Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (2)
Files skipped from review as they are similar to previous changes (1)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- public/locales/en/translation.json (2 hunks)
- src/screens/OrganizationPeople/AddMember.tsx (3 hunks)
Additional comments not posted (3)
src/screens/OrganizationPeople/AddMember.tsx (2)
34-34: Import statement for Avatar component is correct.The import is correctly placed and follows the standard format for importing components in React.
Line range hint
370-409: Layout changes for user profile images are well-implemented.The addition of a new column for user profile images in the member table is correctly implemented using conditional rendering. This enhances the user interface by providing a visual representation of user profiles.
Ensure that the integration with existing user data is seamless and that all user images are correctly displayed or fallback to the default avatar when no image is available.
public/locales/en/translation.json (1)
201-210: Translation additions and updates are correctly implemented.The new translation keys for user-related fields and the update to the "invalidDetailsMessage" are correctly implemented. These changes enhance the localization support, making the user interface more accessible and user-friendly.
Also applies to: 1005-1007
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2254 +/- ##
========================================
Coverage 97.54% 97.54%
========================================
Files 241 241
Lines 6883 6887 +4
Branches 2001 2005 +4
========================================
+ Hits 6714 6718 +4
Misses 157 157
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Thanks for the review. I will make these changes. |
|
Hi @palisadoes , I have added translations for all languages and tests for displaying profile icon in add existing users modal. Could you check if further changes are required? |
Please work on this. We need the test coverage to be better. Our code can only be reliable if it's properly tested. |
Hi @palisadoes! I have added the new test cases. However, I encountered some issues running Codecov for this repository and couldn't verify the test coverage myself. Could you please check if these test cases bring the patch's test coverage to 100%? Thank you for your help. |
What kind of change does this PR introduce?
Issue Number:
Fixes #2232
Did you add tests for your changes?
Yes
Snapshots/Videos:
Translated the headings
Translated the headings and added icons beside the member names.
If relevant, did you update the documentation?
Not relevant here
Summary
This PR fixes the screen layout issues in 'Add Member' functionality in organisations as mentioned in the issue #2232 . The translations are added in translation.json and to add the icons, a new column named 'profile' is created in the modal, which displays the avatar if present, otherwise creates a new avatar for the user.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Add Memberinterface by adding a profile image column for better visual representation of users.Bug Fixes
Tests
OrganizationPeoplecomponent, including validations for displaying user profile images.