Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Leo Login Command Doesn't Ask for Authorization #599

Closed
damons opened this issue Feb 2, 2021 · 3 comments
Closed

[Bug] Leo Login Command Doesn't Ask for Authorization #599

damons opened this issue Feb 2, 2021 · 3 comments
Assignees
@damirka
Labels
bug Something isn't working

Comments

@damons
Copy link

damons commented Feb 2, 2021

🐛 Bug Report

(Write your description here)

Currently login doesn't ask for a password or credentials to authorize a login. I would expect the CLI to ask for a password or equivalent.

Steps to Reproduce

  1. Install Leo 1.0.8.
  2. Run the Leo login command:
$ leo login frank
     Login success
  1. Observe that login was successful and the ~/.leo/credential file was created containing the word frank.

Expected Behavior

I would expect a login to be authorized somehow and a login token, or something, to be added to the ~/.leo dir that is a temporary, maybe, credential that is generated by the server?

Your Environment

Leo 1.0.8
Rust 1.51
macOS Big Sur
@damons damons added the bug Something isn't working label Feb 2, 2021
@damons damons changed the title [Bug] [Bug] Leo Login Command Doesn't Ask for Authorization Feb 2, 2021
@damons
Copy link
Author

damons commented Feb 2, 2021

Could depend on #596

@damirka
Copy link
Contributor

damirka commented Feb 2, 2021

That’s one of the bugs I had written down. If you pass a string (in that case “frank”), cli treats it as a token and stores it in credentials file.

Actually this wasn’t and still isn’t implemented. I’m on it.

@damirka damirka mentioned this issue Feb 4, 2021
Closed
12 tasks
damirka added a commit that referenced this issue Feb 8, 2021
@damirka
Leo CLI is now on StructOpt and Anyhow
2ff2db2 
Features:

- introduces new Command and Route traits for Leo commands and Aleo PM API
- most of the CLI code replace with higher-level abstraction - StructOpt
- anyhow used for error handling, no more custom error classes
- improves API - now every status code has its business logic
- adds global flags (e.g. --quiet to suppress output)
- error messages improved for convenience and better user experience

Closes:

- #604
- #599
- #584
- #277
- #376
@damirka damirka mentioned this issue Feb 8, 2021
Merged
@collinc97
Copy link
Collaborator

Closed by #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damirka damirka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CLI] StructOpt added, code reorganized
3 participants
@damons @damirka @collinc97