-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] StructOpt added, code reorganized #618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 75.63% 74.89% -0.74%
==========================================
Files 518 548 +30
Lines 16135 17245 +1110
==========================================
+ Hits 12204 12916 +712
- Misses 3931 4329 +398
Continue to review full report at Codecov.
|
- checked command descriptions - added update command - added global --quiet flag to suppress all output - added authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like add
, remove
, login
, logout
, and publish
without package
keyword.
@howardwu updated PR. Ready for review again. |
Also fixes #376 - added note in PR description above. When testing library without inputs user receives a warning that no inputs were found:
|
- adds -f flag for leo test command, now you choose files to run - adds tests for leo test - improves output of test command
- PathBuf used instead of String in StructOpt - added dummy-test for logout before login - shortens test cmd code
Reopened as #632 for CI support. |
Motivation
Motivation for this PR has been described here: #584
Short: this not-so-big refactor builds a foundation for future extensions and improvements of CLI application.
Closes #604
Closes #599
Closes #584
Closes #277
Closes #376 (adds warning when no inputs are found)
Closes #596 (won't do)
Changelog
leo login <TOKEN>
now works (didn't before)leo login
work: no token, has token, param missing - everything is in placeanyhow!()
, more error handlers addedcargo test
to use--quiet
or-q
option to suppress output-f
flag toleo test
to test specific file(s)Test Plan
Integration tests for CLI are included