Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Leo CLI outputs "invalid zip archive" if there's no package in PM #604

Closed
damirka opened this issue Feb 3, 2021 · 1 comment
Closed

[Bug] Leo CLI outputs "invalid zip archive" if there's no package in PM #604

damirka opened this issue Feb 3, 2021 · 1 comment
Assignees
@damirka
Labels
bug Something isn't working

Comments

@damirka
Copy link
Contributor

damirka commented Feb 3, 2021

🐛 Bug Report

When trying to import package that is not on Aleo PM, I get the following error (which is confusing):

leo add frank/sinatra

    Adding "invalid Zip archive"
Error: AddError(ZipError("invalid Zip archive"))

Steps to Reproduce

Try using leo add with random author/package.

Expected Behavior

Something like 404 or simple Package Not Found should tell user that he's trying to import non-existent package.
@damirka damirka added the bug Something isn't working label Feb 3, 2021
@damirka damirka self-assigned this Feb 3, 2021
@damirka damirka mentioned this issue Feb 4, 2021
Closed
12 tasks
damirka added a commit that referenced this issue Feb 8, 2021
@damirka
Leo CLI is now on StructOpt and Anyhow
2ff2db2 
Features:

- introduces new Command and Route traits for Leo commands and Aleo PM API
- most of the CLI code replace with higher-level abstraction - StructOpt
- anyhow used for error handling, no more custom error classes
- improves API - now every status code has its business logic
- adds global flags (e.g. --quiet to suppress output)
- error messages improved for convenience and better user experience

Closes:

- #604
- #599
- #584
- #277
- #376
@damirka damirka mentioned this issue Feb 8, 2021
Merged
@collinc97
Copy link
Collaborator

Closed by #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damirka damirka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CLI] StructOpt added, code reorganized
2 participants
@damirka @collinc97