-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namespace.py include colon in ALLOWED_NAME_CHARS #663
Conversation
This commit updates the behavior of is_ncname and split_uri to match the behavior described here: https://www.w3.org/TR/html4/types.html#type-name (found via http://stackoverflow.com/questions/2053132/is-a-colon-safe-for-friendly-url-use). This results in the correct splitting of uris such as http://neurolex.org/wiki/FMA:7191. Extra note that not all user agents conver : -> %3A since they are not required to by the spec (RFC3986).
This makes four of the rdfcore tests fail :( |
This was also changed in turtle at some point, after we got out turtle parser. We would also need to update the turtle parser to be able to parse those localnames with |
When I originally created this I had not chased down the sources of the failures, but as you point it it does break the behvior of the core rdf specification (I have tracked this down for changes I make to NAME_START_CATEGORIES += ["Nd"] which break similar things). I'm not entirely sure what to do about it, but I'm fairly certain that other parsers like the ones used by OWLAPI do have this behavior. |
Removing the |
Looks good! (And apologies for the slow turn around here) |
This merge includes the changes from RDFLib#663 RDFLib#793 RDFLib#827 which were branches tgbugs:fix-uri-spec tgbugs:total-order-patch tgbugs:closed-namespace-attribute-error respectively.
hmmpf, this breaks using our qnames on virtuoso sparql endpoints... |
This commit updates the behavior of is_ncname and
split_uri to match the behavior described here:
https://www.w3.org/TR/html4/types.html#type-name
(found via
http://stackoverflow.com/questions/2053132/is-a-colon-safe-for-friendly-url-use).
This results in the correct splitting of uris such as
http://neurolex.org/wiki/FMA:7191. Extra note that not
all user agents convert : -> %3A since they are not
required to by the spec (RFC3986).