Literal total ordering #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides basic infrastructure for sorting Literals by value where the underlying type has no total ordering. This provides a more consistent solution to issues like: RDFLib#648, RDFLib#630, and RDFLib#613. Where workarounds are implemented in the serializer. This leads to massively increased code complexity in the serializers to compensate for the fact that Literal do not support a total ordering because of some of the underlying python datatypes do not. The only datatype that I know of that causes this issue at the moment is datetime, and I have implemented a fix for that. If other types are found to have this issue the solution is to add an entry to _NO_TOTAL_ORDER_TYPES that includes a function that partitions the type into subtypes that do have total orders.
gYearMonth and gYear (as well as the other g* xsd types) shoud also be included, but their current implementation does not match the xsd spec so they are commented out. If the g* types are implemented as durations or time intervals sorting will likely be a much more complicated issue.
|
Thanks - it would be nice to clean-up any now unnecessary code in serializers, but that can be another PR! |
tgbugs
added a commit
to tgbugs/rdflib
that referenced
this pull request
May 14, 2018
This merge includes the changes from RDFLib#663 RDFLib#793 RDFLib#827 which were branches tgbugs:fix-uri-spec tgbugs:total-order-patch tgbugs:closed-namespace-attribute-error respectively.
joernhees
reviewed
Oct 27, 2018
This was referenced Oct 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides basic infrastructure for sorting Literals by value where the underlying native type has no total ordering. This provides a more consistent solution to issues like: #648, #630, and #613, where workarounds are implemented in the serializer. This leads to massively increased code complexity in the serializers to compensate for the fact that Literal does not support a total ordering because some of the underlying python types do not.
The two types that currently cause issues are datetime and time, but the proposed solution is easily extensible. If other types are found to have this issue the solution is to add an entry to _NO_TOTAL_ORDER_TYPES that includes a function that partitions the type into subtypes that do have total orders.
This pull request also adds test to ensure that types with known issues sort as expected.