ClosedNamespace KeyError -> AttributeError #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raise AttributeError instead of KeyError so that hasattr does not fail
|
Nice and easy! Thanks! |
tgbugs
added a commit
to tgbugs/rdflib
that referenced
this pull request
May 14, 2018
This merge includes the changes from RDFLib#663 RDFLib#793 RDFLib#827 which were branches tgbugs:fix-uri-spec tgbugs:total-order-patch tgbugs:closed-namespace-attribute-error respectively.
|
actually on second thought will change so that the appropriate exception is returned for both...
|
joernhees
added a commit
that referenced
this pull request
Oct 27, 2018
ClosedNamespace returns right exception for way of access, enhances #827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ClosedNamespace raises a KeyError via
__getattr__which breaks hasattr. This patch fixes it by raising an AttributeError instead.