-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separated world and robot models #162
Merged
ROBOTIS-Will
merged 16 commits into
ROBOTIS-GIT:ros2-devel
from
joe28965:galactic-devel
Jun 13, 2021
Merged
separated world and robot models #162
ROBOTIS-Will
merged 16 commits into
ROBOTIS-GIT:ros2-devel
from
joe28965:galactic-devel
Jun 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fake_node pkg, tb3_house
Ros2 devel
Ros2 devel
prepare for release v2.2.2
Ros2 2.2.3 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #115 I removed the robot models from the worlds and instead added them using gazebo_ros spawner.
For compatibility I thought it would be best not to remove any of the now redundant world folders.
I also did a quick update regarding the robot_state_publisher, as
arguments=[urdf])
gives a deprecated warning. Instead it the content of the urdf file should now be included in a parameter.