Various changes #12408

tmbo · 2023-05-17T12:24:05Z

Proposed changes:

added functionality to send a message from a policy using an action. the policy sets the text as metadata for the action. the action will use that text to send an utterance back to the user.

Feel free to fork of this branch to add additional functionality. Let's try to keep the history of this branch clean, as in one commit per feature. Please make sure that tests are passing for the merged changes.

TODO:

remove chat commit 3c2bf60

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

rasa/core/policies/detectors/prompt_sensitive_topic.jinja2

ancalita

Dropping by just as a curiosity, left two passing comments 😄 👍🏻

ancalita · 2023-06-19T08:26:58Z

docs/docs/llms/llm-intentless.mdx

+### End-to-End stories
+
+As part of the beta, we're also releasing a beta version of a new End-To-End
+testing framework. The `rasa test e2e` command allows you to test your bot
+end-to-end, i.e. from the user's perspective. You can use it to test your bot in
+a variety of ways, including testing the `IntentlessPolicy`.
+
+To use the new testing framework, you need to define a set of test cases in a
+test folder, e.g. `tests/e2e_test_stories.yml`. The test cases are defined in a
+similar format as stories are, but contain the user's messages and the bot's
+responses. Here's an example:
+
+```yaml title="tests/e2e_test_stories.yml"
+test_cases:
+  - test_case: transfer charge
+    steps:
+      - user: how can I send money without getting charged?
+      - utter: utter_faq_0
+      - user: not zelle. a normal transfer
+      - utter: utter_faq_7
+```
+
+**Please ensure all your test stories have unique names!** After setting the
+beta feature flag for E2E testing in your current shell with
+`export RASA_PRO_BETA_E2E=true`, you can run the tests with
+`rasa test e2e -f tests/e2e_test_stories.yml`


We should remove this section since there is a different part of the docs dedicated to end-to-end testing.

ancalita · 2023-06-19T08:33:16Z

rasa/server.py

@@ -719,12 +714,18 @@ async def retrieve_tracker(request: Request, conversation_id: Text) -> HTTPRespo
        """Get a dump of a conversation's tracker including its events."""
        verbosity = event_verbosity_parameter(request, EventVerbosity.AFTER_RESTART)
        until_time = rasa.utils.endpoints.float_arg(request, "until")
-
-        tracker = await app.ctx.agent.processor.fetch_full_tracker_with_initial_session(


Why was fetch_full_tracker_with_initial_session removed? I added this method in order to fix a bug reported for the HTTP API 🤔 Only concerned that zombie bugs would reappear.

it is still there, but there is a paraemeter that allows you not to do it. if this is always done, this creates a new tracker in cases you are fetching a non existant conversation and sometimes you don't want to create a tracker for that

Ah yes I see the start_session parameter, but in the else branch get_tracker is used which in turn uses tracker_store.get_or_create_tracker while fetch_full_tracker was using tracker_store.get_or_create_full_tracker 🤔

tmbo · 2023-06-19T08:39:08Z

Dropping by just as a curiosity, left two passing comments 😄 👍🏻

thanks a lot for stopping by 🙂 🙏

m-vdb · 2023-06-20T14:52:37Z

rasa/core/policies/test_flow_policy.py

this file is not under tests/, is this intended?

m-vdb · 2023-06-20T14:52:56Z

rasa/core/actions/tests/test_flows.py

this file is not under the root tests/ folder, is this intended?

tmbo · 2023-06-26T12:51:23Z

rasa/cli/initial_project/domain.yml

@@ -20,6 +20,10 @@ responses:
  utter_did_that_help:
  - text: "Did that help you?"

+  utter_flow_continue_interrupted: 


@twerkmeister should this be here given that the same is in the default flows file?

ancalita

I had a look through the Flows modules primarily and left a few exploratory questions ahead of the call tomorrow morning 🙏🏻

ancalita · 2023-07-12T10:48:02Z

rasa/core/actions/flows.py

+logger = logging.getLogger(__name__)
+
+
+class FlowTriggerAction(action.Action):


Is this action executing the entire of a Flow or only a Flow Step?

ancalita · 2023-07-12T10:48:49Z

rasa/core/actions/flows.py

+            flow_action_name: Name of the flow.
+        """
+        super().__init__()
+        self._flow_name = flow_action_name[len(FLOW_PREFIX) :]


Does this mean that a prefix gets added to all flow names defined in yaml?

ancalita · 2023-07-12T10:50:57Z

rasa/core/actions/flows.py

+        ]
+
+        events: List[Event] = [
+            SlotSet(FLOW_STACK_SLOT, stack.as_dict())


How is this default slot used? Can it get updated with every new flow that gets predicted? What happens to this slot when flows are interlinked?

rasa/core/policies/flow_policy.py

ancalita · 2023-07-12T10:53:14Z

rasa/core/policies/flow_policy.py

+        predicted_action = None
+
+        # if detector predicted an action, we don't want to predict a flow
+        if predicted_action is not None:


When could predicted_action be something else but None?

ancalita · 2023-07-12T10:56:47Z

rasa/shared/core/flows/flow.py

+
+
+@dataclass
+class Flow:


I've seen mentioned meta-flows: what are these and do these come out of the box if flows are enabled, or do users need to write them according to prescriptive instructions?

ancalita · 2023-07-12T10:57:03Z

rasa/shared/core/flows/flow.py

+        available_steps = {step.id for step in self.steps}
+        for step in self.steps:
+            for link in step.next.links:
+                if link.target not in available_steps:


What is a link target?

ancalita · 2023-07-12T11:04:14Z

rasa/shared/core/domain.py

+                self.slots.append(
+                    AnySlot(flow_slot, mappings=[], influence_conversation=False)
+                )
+            else:


When would this occur? If it's overridden in the domain.yml already?

…docs-improvements-llms

Docs improvements

radovanZRasa · 2023-08-29T11:06:56Z

docs/docs/flows.mdx

+Here are some examples of conditions that demonstrate the use of different constructs. 
+
+```yaml
+# Simple conditions


Seems like we should move this to Writing Conditions section.

…builtin slots (#12917) * filter out dialogue stack slot set events from custom actions, mark builtin slots, add unit tests * add comment

moved existing examples into subfolder

Fix generator test folder name

…mmandGenerator Eng 472 component wrap up llm command generator

…appings Tutorial template remove slot mappings

* implement changes + unit test * handle edge case

* Remove EntryPromptFlowStep class. * remove entry_prompt from yaml schema

* Catch KeyError when running the graph. * increase minimum compatibile version to 3.7.0b3 * update model version in test * use constant for minimal compatible version * add changelog * remove changelog as it is not needed * Update error message.

* moved imports of langchain * improve imports

…tion-refactor-tests-review wrap up and tests for flow trigger action

…t values - [ENG 607] (#12942) * modify prompt to include possible categorical slot values

vdanyliv · 2023-11-16T17:46:28Z

@tmbo could you please clarify why this pr is closed? are you still planning to merge flows?

tmbo requested a review from a team as a code owner May 17, 2023 12:24

tmbo removed the request for review from a team May 17, 2023 12:26

tmbo force-pushed the dm2 branch from 76cdd96 to dc3911d Compare May 25, 2023 10:55

m-vdb reviewed Jun 15, 2023

View reviewed changes

rasa/core/policies/detectors/prompt_sensitive_topic.jinja2 Outdated Show resolved Hide resolved

ancalita reviewed Jun 19, 2023

View reviewed changes

m-vdb reviewed Jun 20, 2023

View reviewed changes

tmbo commented Jun 26, 2023

View reviewed changes

tmbo changed the base branch from main to llm-labs June 26, 2023 13:20

Base automatically changed from llm-labs to main July 6, 2023 11:52

ancalita reviewed Jul 12, 2023

View reviewed changes

tmbo and others added 15 commits August 22, 2023 16:44

improvements

97e9fa7

removed context to make space

8857547

WIP - started writing tutorial

736fb57

update tutorial, add to sidebar

8178ddf

removed deliberation

983314b

added branch step

52bf8e7

Merge branch 'docs-improvements-llms' of github.com:RasaHQ/rasa into …

7e1bca0

…docs-improvements-llms

Merge branch 'dm2' into docs-improvements-llms

44e94c3

implemented question flow step as pattern rather than form

adbe843

removed unused code

a9aa71d

fixed linting issue

5740eec

fixed linting issue

08928db

fixed linting issues

513cd30

review commetns

0ca2bd7

Merge pull request #12749 from RasaHQ/docs-improvements-llms

92285e3

Docs improvements

radovanZRasa reviewed Aug 29, 2023

View reviewed changes

tmbo added 3 commits August 29, 2023 15:01

removed unneeded utterance in default project

9b1d499

code style improvements

fc00511

Merge branch 'main' into dm2

5d84e69

Urkem and others added 27 commits October 16, 2023 09:45

fix tests

e45d2e9

fix lint

463c703

chore: fixed type hints for python 3.8.

6eca72a

chore: updated schema for flow in test.

7ec98a2

Disallow dialogue stack slot from being set in custom actions & mark …

ca0e002

…builtin slots (#12917) * filter out dialogue stack slot set events from custom actions, mark builtin slots, add unit tests * add comment

remove comment breaking json

d1d5c0e

fix urls

3b4dbe9

Merge pull request #12860 from RasaHQ/move_examples

7dc7a33

moved existing examples into subfolder

chore: updated render prompt test to test line by line.

09a56a1

prepared release of version 3.8.0a12 (#12922)

ff28dde

chore: corrected test_llm_command_generator.py folder name.

e6e6c3f

Trigger CI

d0e3435

Merge pull request #12925 from RasaHQ/fix-generator-test-folder-name

69fef21

Fix generator test folder name

Merge branch 'dm2' of github.com:RasaHQ/rasa into dm2

eccc758

remove unneeded slot mapping defs

d754306

add description to amount step

0f05c44

Merge branch 'dm2' into ENG-472-Component-Wrap-up-LLMCommandGenerator

2981e0d

Merge pull request #12873 from RasaHQ/ENG-472-Component-Wrap-up-LLMCo…

570c339

…mmandGenerator Eng 472 component wrap up llm command generator

Merge pull request #12928 from RasaHQ/tutorial-template-remove-slot-m…

c0a8cf4

…appings Tutorial template remove slot mappings

Reset slot value for set_slots once flow ends (#12918)

9ae3440

* implement changes + unit test * handle edge case

[ENG-594] Remove entry prompt (#12934)

f71a675

* Remove EntryPromptFlowStep class. * remove entry_prompt from yaml schema

wrap up and tests for flow trigger action

22a66ef

[ENG-586] Moved imports of langchain to speed up rasa --help (#12930)

e0f2cca

* moved imports of langchain * improve imports

test for regular flow

012e466

Merge pull request #12938 from RasaHQ/ENG-584-wrap-up-flow-trigger-ac…

513f42f

…tion-refactor-tests-review wrap up and tests for flow trigger action

Modify LLMCommandGenerator prompt to include possible categorical slo…

864fe08

…t values - [ENG 607] (#12942) * modify prompt to include possible categorical slot values

tmbo closed this Oct 30, 2023

tmbo deleted the dm2 branch November 22, 2023 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various changes #12408

Various changes #12408

tmbo commented May 17, 2023 •

edited

Loading

ancalita left a comment

ancalita Jun 19, 2023

ancalita Jun 19, 2023

tmbo Jun 19, 2023

ancalita Jun 19, 2023

tmbo commented Jun 19, 2023

m-vdb Jun 20, 2023

m-vdb Jun 20, 2023

tmbo Jun 26, 2023

ancalita left a comment

ancalita Jul 12, 2023

ancalita Jul 12, 2023

ancalita Jul 12, 2023

ancalita Jul 12, 2023

ancalita Jul 12, 2023

ancalita Jul 12, 2023

ancalita Jul 12, 2023

radovanZRasa Aug 29, 2023

vdanyliv commented Nov 16, 2023

		logger = logging.getLogger(__name__)


		class FlowTriggerAction(action.Action):

Various changes #12408

Various changes #12408

Conversation

tmbo commented May 17, 2023 • edited Loading

ancalita left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmbo commented Jun 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ancalita left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vdanyliv commented Nov 16, 2023

tmbo commented May 17, 2023 •

edited

Loading