Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Minimized playback): Shorts sometimes incorrectly show the old buggy pip #191

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Oct 20, 2023 · 2 comments · Fixed by ReVanced/revanced-patches-template#3358
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Bug description

If the user plays shorts right after watching a video and then minimizes the app, it'll end up creating the old shorts button abomination of a pip mode which was taken out of minimized playback due to this.

Reference materials & reproduction steps available in ReVanced/revanced-patches-template#214.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Oct 20, 2023
@LisoUseInAIKyrios
Copy link
Contributor

The hook to check if minimized background play is allowed happens before the PlayerType is updated.

After the short is opened and the background play patch hook is called, the player type is still WATCH_WHILE_MINIMIZED, which is a valid state to allow background playback.

The patch needs adjustments.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Oct 20, 2023

@ILoveOpenSourceApplications It should be fixed. Try the dev release and verify it works (integrations v0.120.1-dev.1 and patches v2.195.1-dev.1)

edit: patch did not work, reverting changes.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube - Minimized playback): Shorts are getting the old buggy pip #2 bug(YouTube - Minimized playback): Shorts sometimes incorrectly show the old buggy pip Nov 5, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
oSumAtrIX pushed a commit that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants