fix(YouTube - Minimized playback): Fix PIP incorrectly shown for some Shorts playback #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
approved these changes
Dec 4, 2023
revanced-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
# [3.0.0-dev.4](ReVanced/revanced-patches@v3.0.0-dev.3...v3.0.0-dev.4) (2023-12-04) ### Bug Fixes * **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff))
revanced-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [3.0.0](ReVanced/revanced-patches@v2.202.0...v3.0.0) (2023-12-12) ### Bug Fixes * Use correct class loader to load resources ([1d5f1f8](ReVanced/revanced-patches@1d5f1f8)) * **YouTube - GmsCore support:** Check for availability earlier to prevent crashing without any notice ([dab8900](ReVanced/revanced-patches@dab8900)) * **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff)) * **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409)) ### Features * Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c)) * **Infinity for Reddit - Spoof client:** Support latest version ([ca42fd9](ReVanced/revanced-patches@ca42fd9)) * **Infinity for Reddit:** Add `Unlock subscription` patch ([840b29e](ReVanced/revanced-patches@840b29e)) * **Photomath:** Constrain patches to last working version ([f9a5dc6](ReVanced/revanced-patches@f9a5dc6)) * Publish as a library ([#3356](ReVanced/revanced-patches#3356)) ([4b878ee](ReVanced/revanced-patches@4b878ee)) * **Tiktok:** Bump compatibility to `32.5.3` ([#3389](ReVanced/revanced-patches#3389)) ([96cdc10](ReVanced/revanced-patches@96cdc10)) * **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d)) * **Twitter - Dynamic Color:** Remove blue icon and update app name ([#3384](ReVanced/revanced-patches#3384)) ([3db6615](ReVanced/revanced-patches@3db6615)) * **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6)) * **YouTube:** Add `Change start page` patch ([ad9ba37](ReVanced/revanced-patches@ad9ba37)) * **YouTube:** Clarify patch descriptions ([#3350](ReVanced/revanced-patches#3350)) ([f2b9df4](ReVanced/revanced-patches@f2b9df4)) ### BREAKING CHANGES * **Tiktok:** This removes a patch but consolidates it into another. * Various APIs have been moved to `GmsCoreSupportAbstractPatch`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
There still exists one edge case of:
If these exact steps are taken, the PIP will not show (when normally it should).
Fixing this would require a new hook that determines if the Shorts player is on screen or not. This is an unusual use case, so it's not much concern and this PR fixes the major problem for all situations (a broken Shorts PIP incorrectly showing).
Integration changes