Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Twitch - Settings): Support version 16.1.0 and 15.4.1 #3377

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat(Twitch - Settings): Support version 16.1.0 and 15.4.1 #3377

merged 2 commits into from
Dec 5, 2023

Conversation

LizenzFass78851
Copy link

This will add back the missing versions for Twitch Settings Patch.

Tested successfully with the Twitch version 16.1.0 and 15.4.1

@oSumAtrIX
Copy link
Member

What point does it have?

@LizenzFass78851
Copy link
Author

What point does it have?

When it comes to Twitch patches, version 16.9.1 16.1.0 and 15.4.1 are supported for all advertising and chat patches.

In the settings patch, a past change set this to version 16.9.1 as this is the last version with which the settings patch works.

As mentioned above, version 16.1.0 and 15.4.1 are also supported for the promotional patches and the settings patch should also be supported for the versions mentioned because I also think it works on the versions mentioned.

I also counter-tested it

@oSumAtrIX
Copy link
Member

Patches work with the versions as advertised, but may not work when not. This does not mean they won't. Patches are separate of each other, so adding a version to one for the sake of another patch supporting it is not the correct approach. Even in the case, that multiple patches support distinct versions only. In such a case you'd chose either version and either not use one patch or force patch on that version. The versions are not missing as assumed in the PR title, the versions simply were not necessary for the Settings patch. Coincidentally the patches support one common so you can use all patches as advertised on that version

@oSumAtrIX oSumAtrIX changed the title fix(Twitch - Settings): Support missing version 16.1.0 and 15.4.1 feat(Twitch - Settings): Support version 16.1.0 and 15.4.1 Dec 5, 2023
@oSumAtrIX oSumAtrIX merged commit 062310d into ReVanced:dev Dec 5, 2023
1 check passed
revanced-bot pushed a commit that referenced this pull request Dec 5, 2023
# [3.0.0-dev.6](ReVanced/revanced-patches@v3.0.0-dev.5...v3.0.0-dev.6) (2023-12-05)

### Features

* **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d))
@LizenzFass78851 LizenzFass78851 deleted the twitch--missing-support branch December 5, 2023 16:00
revanced-bot pushed a commit that referenced this pull request Dec 12, 2023
# [3.0.0](ReVanced/revanced-patches@v2.202.0...v3.0.0) (2023-12-12)

### Bug Fixes

* Use correct class loader to load resources ([1d5f1f8](ReVanced/revanced-patches@1d5f1f8))
* **YouTube - GmsCore support:** Check for availability earlier to prevent crashing without any notice ([dab8900](ReVanced/revanced-patches@dab8900))
* **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff))
* **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409))

### Features

* Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c))
* **Infinity for Reddit - Spoof client:** Support latest version ([ca42fd9](ReVanced/revanced-patches@ca42fd9))
* **Infinity for Reddit:** Add `Unlock subscription` patch ([840b29e](ReVanced/revanced-patches@840b29e))
* **Photomath:** Constrain patches to last working version ([f9a5dc6](ReVanced/revanced-patches@f9a5dc6))
* Publish as a library ([#3356](ReVanced/revanced-patches#3356)) ([4b878ee](ReVanced/revanced-patches@4b878ee))
* **Tiktok:** Bump compatibility to `32.5.3` ([#3389](ReVanced/revanced-patches#3389)) ([96cdc10](ReVanced/revanced-patches@96cdc10))
* **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d))
* **Twitter - Dynamic Color:** Remove blue icon and update app name ([#3384](ReVanced/revanced-patches#3384)) ([3db6615](ReVanced/revanced-patches@3db6615))
* **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6))
* **YouTube:** Add `Change start page` patch ([ad9ba37](ReVanced/revanced-patches@ad9ba37))
* **YouTube:** Clarify patch descriptions ([#3350](ReVanced/revanced-patches#3350)) ([f2b9df4](ReVanced/revanced-patches@f2b9df4))

### BREAKING CHANGES

* **Tiktok:** This removes a patch but consolidates it into another.
* Various APIs have been moved to `GmsCoreSupportAbstractPatch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants