feat: Allow choosing the vendor of GmsCore via patch options #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/app/revanced/patches/youtube/misc/microg/MicroGBytecodePatch.kt
LisoUseInAIKyrios
approved these changes
Dec 2, 2023
src/main/kotlin/app/revanced/patches/music/misc/gms/fingerprints/ServiceCheckFingerprint.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/kotlin/app/revanced/patches/music/misc/gms/fingerprints/GooglePlayUtilityFingerprint.kt # src/main/kotlin/app/revanced/patches/music/misc/gms/fingerprints/PrimeMethodFingerprint.kt # src/main/kotlin/app/revanced/patches/music/misc/gms/fingerprints/ServiceCheckFingerprint.kt # src/main/kotlin/app/revanced/patches/youtube/misc/gms/fingerprints/PrimeMethodFingerprint.kt # src/main/kotlin/app/revanced/patches/youtube/misc/microg/fingerprints/CastContextFetchFingerprint.kt # src/main/kotlin/app/revanced/util/microg/MicroGBytecodeHelper.kt # src/main/kotlin/app/revanced/util/microg/MicroGResourceHelper.kt
revanced-bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
# [3.0.0-dev.1](ReVanced/revanced-patches@v2.203.0-dev.2...v3.0.0-dev.1) (2023-12-02) ### Features * Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c)) ### BREAKING CHANGES * Various APIs have been moved to `GmsCoreSupportAbstractPatch`
revanced-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [3.0.0](ReVanced/revanced-patches@v2.202.0...v3.0.0) (2023-12-12) ### Bug Fixes * Use correct class loader to load resources ([1d5f1f8](ReVanced/revanced-patches@1d5f1f8)) * **YouTube - GmsCore support:** Check for availability earlier to prevent crashing without any notice ([dab8900](ReVanced/revanced-patches@dab8900)) * **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff)) * **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409)) ### Features * Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c)) * **Infinity for Reddit - Spoof client:** Support latest version ([ca42fd9](ReVanced/revanced-patches@ca42fd9)) * **Infinity for Reddit:** Add `Unlock subscription` patch ([840b29e](ReVanced/revanced-patches@840b29e)) * **Photomath:** Constrain patches to last working version ([f9a5dc6](ReVanced/revanced-patches@f9a5dc6)) * Publish as a library ([#3356](ReVanced/revanced-patches#3356)) ([4b878ee](ReVanced/revanced-patches@4b878ee)) * **Tiktok:** Bump compatibility to `32.5.3` ([#3389](ReVanced/revanced-patches#3389)) ([96cdc10](ReVanced/revanced-patches@96cdc10)) * **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d)) * **Twitter - Dynamic Color:** Remove blue icon and update app name ([#3384](ReVanced/revanced-patches#3384)) ([3db6615](ReVanced/revanced-patches@3db6615)) * **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6)) * **YouTube:** Add `Change start page` patch ([ad9ba37](ReVanced/revanced-patches@ad9ba37)) * **YouTube:** Clarify patch descriptions ([#3350](ReVanced/revanced-patches#3350)) ([f2b9df4](ReVanced/revanced-patches@f2b9df4)) ### BREAKING CHANGES * **Tiktok:** This removes a patch but consolidates it into another. * Various APIs have been moved to `GmsCoreSupportAbstractPatch`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR refactors the patches for MicroG. It abstracts them so they can be extended for future patches for Google apps and properly generalizes them. In reality, what we previously called MicroG is called GmsCore, which is why the patch has also been renamed.
The patch now includes a patch option that allows specifying the vendor of GmsCore. Currently, the option is set to Vanced as the Vendor of GmsCore, but in the future, this may change to https://github.com/ReVanced/GmsCore, but users of the patch can already use GmsCore by choosing ReVanced as the vendor.
This PR was motivated by someone experiencing issues with Vanced MicroG, but not with our fork of GmsCore and is a step to fully deprecate Vanced MicroG as a vendor of GmsCore.
Key changes
Integrations:
Todo