-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(YouTube - Return YouTube Dislike): Prevent the first Short opened from freezing the UI #3359
Merged
LisoUseInAIKyrios
merged 1 commit into
ReVanced:dev
from
LisoUseInAIKyrios:fix_ryd_shorts_frozen_player
Dec 4, 2023
Merged
fix(YouTube - Return YouTube Dislike): Prevent the first Short opened from freezing the UI #3359
LisoUseInAIKyrios
merged 1 commit into
ReVanced:dev
from
LisoUseInAIKyrios:fix_ryd_shorts_frozen_player
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from freezing the UI
revanced-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
# [3.0.0-dev.3](ReVanced/revanced-patches@v3.0.0-dev.2...v3.0.0-dev.3) (2023-12-04) ### Bug Fixes * **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409))
revanced-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [3.0.0](ReVanced/revanced-patches@v2.202.0...v3.0.0) (2023-12-12) ### Bug Fixes * Use correct class loader to load resources ([1d5f1f8](ReVanced/revanced-patches@1d5f1f8)) * **YouTube - GmsCore support:** Check for availability earlier to prevent crashing without any notice ([dab8900](ReVanced/revanced-patches@dab8900)) * **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff)) * **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409)) ### Features * Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c)) * **Infinity for Reddit - Spoof client:** Support latest version ([ca42fd9](ReVanced/revanced-patches@ca42fd9)) * **Infinity for Reddit:** Add `Unlock subscription` patch ([840b29e](ReVanced/revanced-patches@840b29e)) * **Photomath:** Constrain patches to last working version ([f9a5dc6](ReVanced/revanced-patches@f9a5dc6)) * Publish as a library ([#3356](ReVanced/revanced-patches#3356)) ([4b878ee](ReVanced/revanced-patches@4b878ee)) * **Tiktok:** Bump compatibility to `32.5.3` ([#3389](ReVanced/revanced-patches#3389)) ([96cdc10](ReVanced/revanced-patches@96cdc10)) * **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d)) * **Twitter - Dynamic Color:** Remove blue icon and update app name ([#3384](ReVanced/revanced-patches#3384)) ([3db6615](ReVanced/revanced-patches@3db6615)) * **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6)) * **YouTube:** Add `Change start page` patch ([ad9ba37](ReVanced/revanced-patches@ad9ba37)) * **YouTube:** Clarify patch descriptions ([#3350](ReVanced/revanced-patches#3350)) ([f2b9df4](ReVanced/revanced-patches@f2b9df4)) ### BREAKING CHANGES * **Tiktok:** This removes a patch but consolidates it into another. * Various APIs have been moved to `GmsCoreSupportAbstractPatch`
validcube
pushed a commit
to validcube/revanced-patches
that referenced
this pull request
Aug 6, 2024
…eVanced#3359) Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
validcube
pushed a commit
to validcube/revanced-patches
that referenced
this pull request
Aug 6, 2024
# [4.11.0-dev.1](ReVanced/revanced-patches@v4.10.1-dev.2...v4.11.0-dev.1) (2024-06-27) ### Features * Add `Remove share targets` patch ([#3334](ReVanced/revanced-patches#3334)) ([9414122](ReVanced/revanced-patches@9414122)) * **Instagram:** Add `Hide ads` patch ([#3380](ReVanced/revanced-patches#3380)) ([c6b2f8c](ReVanced/revanced-patches@c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](ReVanced/revanced-patches#3321)) ([8fbe7e3](ReVanced/revanced-patches@8fbe7e3)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](ReVanced/revanced-patches#3359)) ([fbd0507](ReVanced/revanced-patches@fbd0507))
validcube
pushed a commit
to validcube/revanced-patches
that referenced
this pull request
Aug 6, 2024
# [4.11.0](ReVanced/revanced-patches@v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([ReVanced#3379](ReVanced/revanced-patches#3379)) ([b43db98](ReVanced/revanced-patches@b43db98)) * **Windy - Unlock pro:** Revert changing package name ([#3402](ReVanced/revanced-patches#3402)) ([541f1e7](ReVanced/revanced-patches@541f1e7)) * **Windy - Unlock pro:** Use correct package name ([#3397](ReVanced/revanced-patches#3397)) ([1d8459a](ReVanced/revanced-patches@1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([#3365](ReVanced/revanced-patches#3365)) ([6aa47ec](ReVanced/revanced-patches@6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([#3415](ReVanced/revanced-patches#3415)) ([7201ac4](ReVanced/revanced-patches@7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([#3331](ReVanced/revanced-patches#3331)) ([d9395fd](ReVanced/revanced-patches@d9395fd)) ### Features * Add `Remove share targets` patch ([#3334](ReVanced/revanced-patches#3334)) ([9414122](ReVanced/revanced-patches@9414122)) * Add translations ([ReVanced#2963](ReVanced/revanced-patches#2963)) ([69ea6f3](ReVanced/revanced-patches@69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([#3366](ReVanced/revanced-patches#3366)) ([ad8d3bb](ReVanced/revanced-patches@ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([#3380](ReVanced/revanced-patches#3380)) ([c6b2f8c](ReVanced/revanced-patches@c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](ReVanced/revanced-patches#3321)) ([8fbe7e3](ReVanced/revanced-patches@8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([#3386](ReVanced/revanced-patches#3386)) ([3c79f3d](ReVanced/revanced-patches@3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](ReVanced/revanced-patches#3359)) ([fbd0507](ReVanced/revanced-patches@fbd0507))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with the synchronous approach of modifying litho Shorts dislikes.
It does this by waiting for RYD to finish fetching when the first Short is opened.
Also adds a 'video is Short' method to
VideoInformation
by using the player parameters to detect if the video is Short. This works much better for many situations wherePlayerType
does not always correctly indicate Short status, and also can fix issues such as #191 (fix for that will come in a separate commit)integration changes