Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Alternative Thumbnails): Add option to use DeArrow #3378

Merged
merged 16 commits into from
Dec 11, 2023

Conversation

shadow578
Copy link

@shadow578 shadow578 commented Dec 5, 2023

adds the option to use thumbnails provided by DeArrow to the existing alternative thumbnails patch

requires ReVanced/revanced-integrations#534

@oSumAtrIX oSumAtrIX changed the title feat(YouTube): add DeArrow option for Alternative Thumbnails Patch feat(YouTube - Alternative Thumbnails): Add option to use DeArrow Dec 5, 2023
@oSumAtrIX oSumAtrIX changed the base branch from main to dev December 5, 2023 17:39
@LisoUseInAIKyrios
Copy link

@oSumAtrIX
After changing the summary of NonInteractivePreference to optional, this PR is now failing with an apiCheck:
https://github.com/ReVanced/revanced-patches/actions/runs/7114700498/job/19369374387#step:5:51

Is there something that needs adjusting here?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 6, 2023

Run the Gradle task API dump. The task is ensuring the public API ist being changed unintentionally as soon other patch repositories can use it. Breaking changes should be avoided by deprecation. If the API check fails, it may indicate a breaking change, but not necessarily. In this case you just dump the API and commit it with the change. If it is a breaking change you commit it as one using the BREAKING CHANGE footer.

More info here: https://github.com/Kotlin/binary-compatibility-validator

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 41217f6 into ReVanced:dev Dec 11, 2023
2 checks passed
revanced-bot pushed a commit that referenced this pull request Dec 11, 2023
# [3.0.0-dev.8](ReVanced/revanced-patches@v3.0.0-dev.7...v3.0.0-dev.8) (2023-12-11)

### Features

* **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6))
revanced-bot pushed a commit that referenced this pull request Dec 12, 2023
# [3.0.0](ReVanced/revanced-patches@v2.202.0...v3.0.0) (2023-12-12)

### Bug Fixes

* Use correct class loader to load resources ([1d5f1f8](ReVanced/revanced-patches@1d5f1f8))
* **YouTube - GmsCore support:** Check for availability earlier to prevent crashing without any notice ([dab8900](ReVanced/revanced-patches@dab8900))
* **YouTube - Minimized playback:** Fix PIP incorrectly shown for some Shorts playback ([#3364](ReVanced/revanced-patches#3364)) ([84607ff](ReVanced/revanced-patches@84607ff))
* **YouTube - Return YouTube Dislike:** Prevent the first Short opened from freezing the UI ([#3359](ReVanced/revanced-patches#3359)) ([e024409](ReVanced/revanced-patches@e024409))

### Features

* Allow choosing the vendor of GmsCore via patch options ([#3347](ReVanced/revanced-patches#3347)) ([161261c](ReVanced/revanced-patches@161261c))
* **Infinity for Reddit - Spoof client:** Support latest version ([ca42fd9](ReVanced/revanced-patches@ca42fd9))
* **Infinity for Reddit:** Add `Unlock subscription` patch ([840b29e](ReVanced/revanced-patches@840b29e))
* **Photomath:** Constrain patches to last working version ([f9a5dc6](ReVanced/revanced-patches@f9a5dc6))
* Publish as a library ([#3356](ReVanced/revanced-patches#3356)) ([4b878ee](ReVanced/revanced-patches@4b878ee))
* **Tiktok:** Bump compatibility to `32.5.3` ([#3389](ReVanced/revanced-patches#3389)) ([96cdc10](ReVanced/revanced-patches@96cdc10))
* **Twitch - Settings:** Support version `16.1.0` and `15.4.1` ([#3377](ReVanced/revanced-patches#3377)) ([062310d](ReVanced/revanced-patches@062310d))
* **Twitter - Dynamic Color:** Remove blue icon and update app name ([#3384](ReVanced/revanced-patches#3384)) ([3db6615](ReVanced/revanced-patches@3db6615))
* **YouTube - Alternative Thumbnails:** Add option to use DeArrow ([#3378](ReVanced/revanced-patches#3378)) ([41217f6](ReVanced/revanced-patches@41217f6))
* **YouTube:** Add `Change start page` patch ([ad9ba37](ReVanced/revanced-patches@ad9ba37))
* **YouTube:** Clarify patch descriptions ([#3350](ReVanced/revanced-patches#3350)) ([f2b9df4](ReVanced/revanced-patches@f2b9df4))

### BREAKING CHANGES

* **Tiktok:** This removes a patch but consolidates it into another.
* Various APIs have been moved to `GmsCoreSupportAbstractPatch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants