`Offline Entitlements`: use offline-computed `CustomerInfo` when server is down #2368

NachoSoto · 2023-03-23T00:47:39Z

Changes:

Created PurchasedProductsFetcherType to be able to mock and hold fetchers, even on older devices
Created ProductEntitlementMappingFetcher to abstract injecting ProductEntitlementMapping
Added logic to CustomerInfoResponseHandler to compute offline CustomerInfo after a server error (see Implemented NetworkError.isServerDown #2367). This is used by all CustomerInfo requests as well as PostReceiptDataOperation.
Wrote comprehensive CustomerInfoResponseHandler tests

TODO:

Don't cache offline computed CustomerInfo: CustomerInfoManager: don't cache offline CustomerInfo #2378
Integration tests: Offline Entitlements: integration tests #2501.

NachoSoto · 2023-03-23T19:21:25Z

Sources/OfflineEntitlements/PurchasedProductsFetcher.swift

+final class VoidPurchasedProductsFetcher: PurchasedProductsFetcherType {
+
+    func fetchPurchasedProducts() async throws -> [PurchasedSK2Product] {
+        assertionFailure("This should never be used")


This will only crash in DEBUG builds. We only create this prior to iOS15, where offline CustomerInfos aren't computed.

tonidero

Great job on this! I think we are handling all cases pretty well now 👍

Sources/OfflineEntitlements/OfflineCustomerInfoCreator.swift

tonidero · 2023-05-19T08:58:35Z

Tests/UnitTests/Mocks/MockOfflineEntitlementsManager.swift

@@ -7,7 +7,7 @@
 //
 //      https://opensource.org/licenses/MIT
 //
-//  MockOfflineEntitlementsManager.swift
+//  MockOfflineEntitlementsManager.swiftz


NABD but unintended change?

Oops thanks

Fixing in the next PR to avoid running CI just for this 😅

tonidero

Great job on this! I think we are handling all cases pretty well now 👍

commit 8c4db197c672d6811d910b38264f9a3ff153e196 Author: NachoSoto <ignaciosoto90@gmail.com> Date: Thu May 18 14:12:11 2023 -0700 `PurchasedProductsFetcher`: cache current entitlements To optimize potentially computing offline `CustomerInfo`, this caches what's likely the most expensive part. commit aca83398650df220dbdb11b8f2cc6f3656b140d3 Author: NachoSoto <ignaciosoto90@gmail.com> Date: Thu May 18 13:35:10 2023 -0700 `PurchasedProductsFetcher`: don't throw errors if purchased products were found This is a best-effort implementation. We can still compute the offline `CustomerInfo` if we found some purchased products. Extracted from RevenueCat#2368 and added tests.

NachoSoto · 2023-05-19T17:26:38Z

I did some initial sanity check and this is working well, so merging!
Will still do more manual testing before releasing.

…were found This is a best-effort implementation. We can still compute the offline `CustomerInfo` if we found some purchased products. Extracted from #2368 and added tests.

…were found (#2506) This is a best-effort implementation. We can still compute the offline `CustomerInfo` if we found some purchased products. Extracted from #2368 and added tests.

@NachoSoto

**This is an automatic release.** ### New Features * `Offline Entitlements`: use offline-computed `CustomerInfo` when server is down (#2368) via NachoSoto (@NachoSoto) ### Bugfixes * `AppleReceipt.debugDescription`: don't pretty-print JSON (#2564) via NachoSoto (@NachoSoto) * `SK2StoreProduct`: fix crash on iOS 12 (#2565) via NachoSoto (@NachoSoto) * `GetCustomerInfo` posts receipts if there are pending transactions (#2533) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasedProductsFetcher`: cache current entitlements (#2507) via NachoSoto (@NachoSoto) * Performance: new check to ensure serialization / deserialization is done from background thread (#2496) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane from 2.212.2 to 2.213.0 (#2544) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `CustomerInfoManager`: post all unfinished transactions (#2563) via NachoSoto (@NachoSoto) * `PostReceiptOperation`: added ability to also post `AdServices` token (#2566) via NachoSoto (@NachoSoto) * `Offline Entitlements`: improved computation log (#2562) via NachoSoto (@NachoSoto) * Added `TransactionPoster` tests (#2557) via NachoSoto (@NachoSoto) * Refactored `TransactionPoster`: removed 2 dependencies and abstracted parameters (#2542) via NachoSoto (@NachoSoto) * `CustomerInfoManagerTests`: wait for `getAndCacheCustomerInfo` to finish (#2555) via NachoSoto (@NachoSoto) * `StoreTransaction`: implemented `description` (#2556) via NachoSoto (@NachoSoto) * `Backend.ResponseHandler` is now `@Sendable` (#2541) via NachoSoto (@NachoSoto) * Extracted `TransactionPoster` from `PurchasesOrchestrator` (#2540) via NachoSoto (@NachoSoto) * `enableAdServicesAttributionTokenCollection`: added integration test (#2551) via NachoSoto (@NachoSoto) * `AttributionPoster`: replaced hardcoded strings with constants (#2548) via NachoSoto (@NachoSoto) * `DefaultDecodable`: moved to `Misc/Codable/DefaultDecodable.swift` (#2528) via NachoSoto (@NachoSoto) * `CircleCI`: specify device to run `backend_integration_tests` (#2547) via NachoSoto (@NachoSoto) * Created `StoreKit2TransactionFetcher` (#2539) via NachoSoto (@NachoSoto) * Fix load shedder integration tests (#2546) via Josh Holtz (@joshdholtz) * Fix doc on `Offering.getMetadataValue` (#2545) via Josh Holtz (@joshdholtz) * Extracted and tested `AsyncSequence.extractValues` (#2538) via NachoSoto (@NachoSoto) * `Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products (#2522) via NachoSoto (@NachoSoto) * `OfflineEntitlementsManager`: disable offline `CustomerInfo` in observer mode (#2520) via NachoSoto (@NachoSoto) * `BasePurchasesTests`: fixed leak detection (#2534) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added `ProxyView` to `iOS` (#2531) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: removed `AppStore.sync` call (#2521) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added new window on Mac to manage proxy (#2518) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: added log if fetching purchased products is slow (#2515) via NachoSoto (@NachoSoto) * `Offline Entitlements`: disable for custom entitlements mode (#2509) via NachoSoto (@NachoSoto) * `Offline Entitlements`: fixed iOS 12 tests (#2514) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: don't throw errors if purchased products were found (#2506) via NachoSoto (@NachoSoto) * `Offline Entitlements`: allow creating offline `CustomerInfo` with empty `ProductEntitlementMapping` (#2504) via NachoSoto (@NachoSoto) * `Offline Entitlements`: integration tests (#2501) via NachoSoto (@NachoSoto) * `CustomerInfoManager`: don't cache offline `CustomerInfo` (#2378) via NachoSoto (@NachoSoto) * `DangerousSettings`: debug-only `forceServerErrors` (#2486) via NachoSoto (@NachoSoto) * `CocoapodsInstallation`: fixed `Xcode 14.3.0` issue (#2489) via NachoSoto (@NachoSoto) * `CarthageInstallation`: removed workaround (#2488) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>

NachoSoto added the pr:fix A bug fix label Mar 23, 2023

NachoSoto requested a review from a team March 23, 2023 00:47

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch 2 times, most recently from 751d43d to 252ab9a Compare March 23, 2023 02:57

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch 2 times, most recently from c7ebe2a to 22d18c2 Compare March 23, 2023 16:42

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 252ab9a to 652b749 Compare March 23, 2023 16:44

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from 22d18c2 to d4f3c46 Compare March 23, 2023 16:50

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch 2 times, most recently from 1855511 to 5b90cfb Compare March 23, 2023 17:04

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from f96ff45 to 378d554 Compare March 23, 2023 17:07

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 5b90cfb to 5d5f878 Compare March 23, 2023 17:07

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from 378d554 to cadce12 Compare March 23, 2023 17:26

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch 7 times, most recently from d5f8771 to 9ef25ab Compare March 23, 2023 19:01

NachoSoto changed the title ~~[WIP] Offline Entitlements: use offline-computed CustomerInfo when server is down~~ Offline Entitlements: use offline-computed CustomerInfo when server is down Mar 23, 2023

NachoSoto marked this pull request as ready for review March 23, 2023 19:14

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 9ef25ab to bc58d36 Compare March 23, 2023 19:14

NachoSoto commented Mar 23, 2023

View reviewed changes

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from cadce12 to c00cfdb Compare March 23, 2023 20:06

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from bc58d36 to dfbb492 Compare March 23, 2023 20:14

NachoSoto force-pushed the nacho/sdk-2987-compute-customerinfo-from-a-list-of branch from 276d952 to 72033e0 Compare March 23, 2023 22:37

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 3b4d9eb to 6dfeb74 Compare March 23, 2023 22:37

Base automatically changed from nacho/sdk-2987-compute-customerinfo-from-a-list-of to main March 24, 2023 17:41

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 6dfeb74 to c94a25a Compare March 24, 2023 17:46

NachoSoto added 5 commits May 18, 2023 10:40

Don't finish transactions when computing offline CustomerInfo

0cd59f4

Clear customer info cache when fetching offline customer info

6142108

Removed VoidPurchasedProductsFetcher

8f6b166

Refactored into OfflineCustomerInfoCreator

b1902f9

Added tests for isComputedOffline

777318f

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 14d252b to 777318f Compare May 18, 2023 17:40

NachoSoto mentioned this pull request May 18, 2023

PurchasedProductsFetcher: don't throw errors if purchased products were found #2506

Merged

NachoSoto added 3 commits May 18, 2023 14:15

Removed changes from other branch

de9b92b

Don't compute offline customer info if there is something cached

ff8c1f5

Fixed logic

f1754ce

NachoSoto requested a review from tonidero May 18, 2023 22:09

Further refactor

8459cb7

NachoSoto force-pushed the nacho/sdk-2991-write-flow-to-use-locally-computed branch from 6115e26 to 8459cb7 Compare May 18, 2023 23:52

tonidero approved these changes May 19, 2023

View reviewed changes

NachoSoto merged commit 99c8a34 into main May 19, 2023

NachoSoto deleted the nacho/sdk-2991-write-flow-to-use-locally-computed branch May 19, 2023 17:27

RCGitBot mentioned this pull request May 24, 2023

[AUTOMATIC] Release/4.20.0 #2537

Closed

This was referenced May 31, 2023

[AUTOMATIC] Release/4.21.0 #2569

Closed

[AUTOMATIC] Release/4.21.0 #2571

Merged

NachoSoto mentioned this pull request May 31, 2023

Release/4.20.1 #2572

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Offline Entitlements`: use offline-computed `CustomerInfo` when server is down #2368

`Offline Entitlements`: use offline-computed `CustomerInfo` when server is down #2368

NachoSoto commented Mar 23, 2023 •

edited

Loading

NachoSoto Mar 23, 2023

tonidero left a comment

tonidero May 19, 2023

NachoSoto May 19, 2023

NachoSoto May 19, 2023

tonidero left a comment

NachoSoto commented May 19, 2023

Offline Entitlements: use offline-computed CustomerInfo when server is down #2368

Offline Entitlements: use offline-computed CustomerInfo when server is down #2368

Conversation

NachoSoto commented Mar 23, 2023 • edited Loading

Changes:

TODO:

NachoSoto Mar 23, 2023

Choose a reason for hiding this comment

tonidero left a comment

Choose a reason for hiding this comment

tonidero May 19, 2023

Choose a reason for hiding this comment

NachoSoto May 19, 2023

Choose a reason for hiding this comment

NachoSoto May 19, 2023

Choose a reason for hiding this comment

tonidero left a comment

Choose a reason for hiding this comment

NachoSoto commented May 19, 2023

`Offline Entitlements`: use offline-computed `CustomerInfo` when server is down #2368

`Offline Entitlements`: use offline-computed `CustomerInfo` when server is down #2368

NachoSoto commented Mar 23, 2023 •

edited

Loading