CustomerInfoManager: don't cache offline CustomerInfo
#2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
from
3a1e8db
to
6299912
Compare
2 tasks
vegaro
approved these changes
Mar 24, 2023
NachoSoto
force-pushed
the
nacho/sdk-2991-write-flow-to-use-locally-computed
branch
from
58d97c8
to
0ebbb54
Compare
Codecov Report
@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
- Coverage 87.70% 86.84% -0.87%
==========================================
Files 197 198 +1
Lines 13327 13364 +37
==========================================
- Hits 11689 11606 -83
- Misses 1638 1758 +120
|
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
from
883a606
to
2eefe0b
Compare
NachoSoto
force-pushed
the
nacho/sdk-2991-write-flow-to-use-locally-computed
branch
from
0ebbb54
to
1e86508
Compare
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
3 times, most recently
from
d546aae
to
20ef64c
Compare
NachoSoto
force-pushed
the
nacho/sdk-2991-write-flow-to-use-locally-computed
branch
from
1e86508
to
275cd71
Compare
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
from
20ef64c
to
95abf7b
Compare
NachoSoto
force-pushed
the
nacho/sdk-2991-write-flow-to-use-locally-computed
branch
from
2da1a32
to
1f385f9
Compare
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
from
95abf7b
to
08582ea
Compare
NachoSoto
force-pushed
the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
from
08582ea
to
c19f1cf
Compare
NachoSoto
changed the base branch from
nacho/sdk-2991-write-flow-to-use-locally-computed
to
main
|
Rebased this off of |
NachoSoto
deleted the
nacho/sdk-3029-change-offline-customerinfo-verification
branch
NachoSoto
added a commit
that referenced
this pull request
May 19, 2023
…er is down (#2368) ### Changes: - Created `PurchasedProductsFetcherType` to be able to mock and hold fetchers, even on older devices - Created `ProductEntitlementMappingFetcher` to abstract injecting `ProductEntitlementMapping` - Added logic to `CustomerInfoResponseHandler` to compute offline `CustomerInfo` after a server error (see #2367). **This is used by all `CustomerInfo` requests as well as `PostReceiptDataOperation`**. - Wrote comprehensive `CustomerInfoResponseHandler` tests ### TODO: - [x] Don't cache offline computed `CustomerInfo`: #2378 - [x] Integration tests: #2501.
This was referenced May 31, 2023
Closed
NachoSoto
added a commit
that referenced
this pull request
Jun 1, 2023
**This is an automatic release.** ### New Features * `Offline Entitlements`: use offline-computed `CustomerInfo` when server is down (#2368) via NachoSoto (@NachoSoto) ### Bugfixes * `AppleReceipt.debugDescription`: don't pretty-print JSON (#2564) via NachoSoto (@NachoSoto) * `SK2StoreProduct`: fix crash on iOS 12 (#2565) via NachoSoto (@NachoSoto) * `GetCustomerInfo` posts receipts if there are pending transactions (#2533) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasedProductsFetcher`: cache current entitlements (#2507) via NachoSoto (@NachoSoto) * Performance: new check to ensure serialization / deserialization is done from background thread (#2496) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane from 2.212.2 to 2.213.0 (#2544) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `CustomerInfoManager`: post all unfinished transactions (#2563) via NachoSoto (@NachoSoto) * `PostReceiptOperation`: added ability to also post `AdServices` token (#2566) via NachoSoto (@NachoSoto) * `Offline Entitlements`: improved computation log (#2562) via NachoSoto (@NachoSoto) * Added `TransactionPoster` tests (#2557) via NachoSoto (@NachoSoto) * Refactored `TransactionPoster`: removed 2 dependencies and abstracted parameters (#2542) via NachoSoto (@NachoSoto) * `CustomerInfoManagerTests`: wait for `getAndCacheCustomerInfo` to finish (#2555) via NachoSoto (@NachoSoto) * `StoreTransaction`: implemented `description` (#2556) via NachoSoto (@NachoSoto) * `Backend.ResponseHandler` is now `@Sendable` (#2541) via NachoSoto (@NachoSoto) * Extracted `TransactionPoster` from `PurchasesOrchestrator` (#2540) via NachoSoto (@NachoSoto) * `enableAdServicesAttributionTokenCollection`: added integration test (#2551) via NachoSoto (@NachoSoto) * `AttributionPoster`: replaced hardcoded strings with constants (#2548) via NachoSoto (@NachoSoto) * `DefaultDecodable`: moved to `Misc/Codable/DefaultDecodable.swift` (#2528) via NachoSoto (@NachoSoto) * `CircleCI`: specify device to run `backend_integration_tests` (#2547) via NachoSoto (@NachoSoto) * Created `StoreKit2TransactionFetcher` (#2539) via NachoSoto (@NachoSoto) * Fix load shedder integration tests (#2546) via Josh Holtz (@joshdholtz) * Fix doc on `Offering.getMetadataValue` (#2545) via Josh Holtz (@joshdholtz) * Extracted and tested `AsyncSequence.extractValues` (#2538) via NachoSoto (@NachoSoto) * `Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products (#2522) via NachoSoto (@NachoSoto) * `OfflineEntitlementsManager`: disable offline `CustomerInfo` in observer mode (#2520) via NachoSoto (@NachoSoto) * `BasePurchasesTests`: fixed leak detection (#2534) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added `ProxyView` to `iOS` (#2531) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: removed `AppStore.sync` call (#2521) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added new window on Mac to manage proxy (#2518) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: added log if fetching purchased products is slow (#2515) via NachoSoto (@NachoSoto) * `Offline Entitlements`: disable for custom entitlements mode (#2509) via NachoSoto (@NachoSoto) * `Offline Entitlements`: fixed iOS 12 tests (#2514) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: don't throw errors if purchased products were found (#2506) via NachoSoto (@NachoSoto) * `Offline Entitlements`: allow creating offline `CustomerInfo` with empty `ProductEntitlementMapping` (#2504) via NachoSoto (@NachoSoto) * `Offline Entitlements`: integration tests (#2501) via NachoSoto (@NachoSoto) * `CustomerInfoManager`: don't cache offline `CustomerInfo` (#2378) via NachoSoto (@NachoSoto) * `DangerousSettings`: debug-only `forceServerErrors` (#2486) via NachoSoto (@NachoSoto) * `CocoapodsInstallation`: fixed `Xcode 14.3.0` issue (#2489) via NachoSoto (@NachoSoto) * `CarthageInstallation`: removed workaround (#2488) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be a temporary
CustomerInfowhile the backend is offline.See also #2368.