`Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products #2522

NachoSoto · 2023-05-22T20:04:56Z

This will be logged when doing so:

ERROR: 😿 ❗❗ Error computing offline CustomerInfo. Will return original error.
Creation error: Unable to compute offline CustomerInfo when purchasing consumable products.

Changes:

Added unit tests for PostReceiptDataOperation
Added integration test for this new scenario
PostReceiptDataOperation won't use OfflineCustomerInfoCreator when purchasing consumable products

NachoSoto · 2023-05-22T20:05:18Z

I ended up going with this approach which I think is much more elegant. Avoids having to parse the local receipt unnecessarily.

codecov · 2023-05-22T20:55:15Z

Codecov Report

Merging #2522 (a55721e) into main (c48b080) will decrease coverage by 0.09%.
The diff coverage is 40.62%.

❗ Current head a55721e differs from pull request most recent head 3184abf. Consider uploading reports for the commit 3184abf to get more accurate results

@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   87.82%   87.74%   -0.09%     
==========================================
  Files         199      199              
  Lines       13743    13726      -17     
==========================================
- Hits        12070    12044      -26     
- Misses       1673     1682       +9

Impacted Files	Coverage Δ
...OfflineEntitlements/PurchasedProductsFetcher.swift	`69.23% <37.93%> (-19.66%)`	⬇️
...s/Logging/Strings/OfflineEntitlementsStrings.swift	`81.48% <66.66%> (-2.84%)`	⬇️

... and 13 files with indirect coverage changes

tonidero · 2023-05-23T08:22:43Z

Sources/Networking/Operations/PostReceiptDataOperation.swift

@@ -39,11 +39,16 @@ final class PostReceiptDataOperation: CacheableNetworkOperation {
        customerInfoCallbackCache: CallbackCache<CustomerInfoCallback>,
        offlineCustomerInfoCreator: OfflineCustomerInfoCreator?
    ) -> CacheableNetworkOperationFactory<PostReceiptDataOperation> {
+        // Can't compute offline CustomerInfo when purchasing non-consumables
+        let offlineCreator: OfflineCustomerInfoCreator? = postData.isNonSubscriptionProduct


Hmm so this will only work when posting a receipt right? I don't think this will handle this scenario:

User purchases a consumable while offline (the post fails)

For some reason, they invalidate customer info or uninstall/reinstall (so no customer info cached)

They restart the app

During restart, get customer info request fails with a 5xx, so we try to enter offline entitlements even though it has a consumable.

Admittedly, this seems like an uncommon case (users invalidating customer info in the middle), but ideally we would also handle it.

Thanks for pointing this out. The new implementation fixes that 👍🏻
Also I think it's much cleaner moving the check to use StoreKit.Transaction.unfinished.

tonidero

LGTM!

tonidero · 2023-05-24T08:14:54Z

Sources/OfflineEntitlements/PurchasedProductsFetcher.swift

@@ -97,4 +101,48 @@ class PurchasedProductsFetcher: PurchasedProductsFetcherType {
        return result
    }

+    private static var hasPendingConsumablePurchase: Bool {


Is it possible to unit test these? I guess we would have to mock StoreKit. We do have integration tests so it's probably okish, but I think it's good to test things at different granularities to try to have as much coverage as possible.

It's indirectly tested, but I agree it would be useful to test independently 👍🏻 which we can do with SKTestSession.

I added a type in #2533 to do something similar, so I'm going to combine both things and test them.

Extracted and tested in #2539 like you suggested.

tonidero · 2023-05-24T08:18:58Z

Sources/OfflineEntitlements/PurchasedProductsFetcher.swift

@@ -97,4 +101,48 @@ class PurchasedProductsFetcher: PurchasedProductsFetcherType {
        return result
    }

+    private static var hasPendingConsumablePurchase: Bool {
+        get async {
+            return await StoreKit.Transaction.unfinished.contains {


Just to check, but I'm guessing SK2 will cache the transactions internally right? So this shouldn't take too long.

Also, will this be executed in a background thread? I'm guessing since the API is using async/await that might be handled internally by SK2 though.

The short answer is: it doesn't matter. Concurrency in Swift is different from what you'd expect. Even if this takes 1 hour, it's not stopping the thread, it creates a continuation.

…chasing a consumable product ### Changes: - Added unit tests for `PostReceiptDataOperation` - Added integration test for this new scenario - `PostReceiptDataOperation` won't use `OfflineCustomerInfoCreator` when purchasing consumable products

… ios-15 (#2523)

… ios-14 (#2524)

@NachoSoto

… ios-12 (#2526) Requested by @NachoSoto for [nacho/sdk-3030-test-consumables](https://github.com/RevenueCat/purchases-ios/tree/nacho/sdk-3030-test-consumables) Co-authored-by: Distiller <distiller@static.38.39.184.83.cyberlynk.net>

@NachoSoto

… ios-16 (#2525) Requested by @NachoSoto for [nacho/sdk-3030-test-consumables](https://github.com/RevenueCat/purchases-ios/tree/nacho/sdk-3030-test-consumables) Co-authored-by: Distiller <distiller@static.38.23.39.112.cyberlynk.net>

@NachoSoto

… ios-13 (#2527) Requested by @NachoSoto for [nacho/sdk-3030-test-consumables](https://github.com/RevenueCat/purchases-ios/tree/nacho/sdk-3030-test-consumables) Co-authored-by: Distiller <distiller@static.38.23.38.23.cyberlynk.net>

@NachoSoto

**This is an automatic release.** ### New Features * `Offline Entitlements`: use offline-computed `CustomerInfo` when server is down (#2368) via NachoSoto (@NachoSoto) ### Bugfixes * `AppleReceipt.debugDescription`: don't pretty-print JSON (#2564) via NachoSoto (@NachoSoto) * `SK2StoreProduct`: fix crash on iOS 12 (#2565) via NachoSoto (@NachoSoto) * `GetCustomerInfo` posts receipts if there are pending transactions (#2533) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasedProductsFetcher`: cache current entitlements (#2507) via NachoSoto (@NachoSoto) * Performance: new check to ensure serialization / deserialization is done from background thread (#2496) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane from 2.212.2 to 2.213.0 (#2544) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `CustomerInfoManager`: post all unfinished transactions (#2563) via NachoSoto (@NachoSoto) * `PostReceiptOperation`: added ability to also post `AdServices` token (#2566) via NachoSoto (@NachoSoto) * `Offline Entitlements`: improved computation log (#2562) via NachoSoto (@NachoSoto) * Added `TransactionPoster` tests (#2557) via NachoSoto (@NachoSoto) * Refactored `TransactionPoster`: removed 2 dependencies and abstracted parameters (#2542) via NachoSoto (@NachoSoto) * `CustomerInfoManagerTests`: wait for `getAndCacheCustomerInfo` to finish (#2555) via NachoSoto (@NachoSoto) * `StoreTransaction`: implemented `description` (#2556) via NachoSoto (@NachoSoto) * `Backend.ResponseHandler` is now `@Sendable` (#2541) via NachoSoto (@NachoSoto) * Extracted `TransactionPoster` from `PurchasesOrchestrator` (#2540) via NachoSoto (@NachoSoto) * `enableAdServicesAttributionTokenCollection`: added integration test (#2551) via NachoSoto (@NachoSoto) * `AttributionPoster`: replaced hardcoded strings with constants (#2548) via NachoSoto (@NachoSoto) * `DefaultDecodable`: moved to `Misc/Codable/DefaultDecodable.swift` (#2528) via NachoSoto (@NachoSoto) * `CircleCI`: specify device to run `backend_integration_tests` (#2547) via NachoSoto (@NachoSoto) * Created `StoreKit2TransactionFetcher` (#2539) via NachoSoto (@NachoSoto) * Fix load shedder integration tests (#2546) via Josh Holtz (@joshdholtz) * Fix doc on `Offering.getMetadataValue` (#2545) via Josh Holtz (@joshdholtz) * Extracted and tested `AsyncSequence.extractValues` (#2538) via NachoSoto (@NachoSoto) * `Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products (#2522) via NachoSoto (@NachoSoto) * `OfflineEntitlementsManager`: disable offline `CustomerInfo` in observer mode (#2520) via NachoSoto (@NachoSoto) * `BasePurchasesTests`: fixed leak detection (#2534) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added `ProxyView` to `iOS` (#2531) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: removed `AppStore.sync` call (#2521) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: added new window on Mac to manage proxy (#2518) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: added log if fetching purchased products is slow (#2515) via NachoSoto (@NachoSoto) * `Offline Entitlements`: disable for custom entitlements mode (#2509) via NachoSoto (@NachoSoto) * `Offline Entitlements`: fixed iOS 12 tests (#2514) via NachoSoto (@NachoSoto) * `PurchasedProductsFetcher`: don't throw errors if purchased products were found (#2506) via NachoSoto (@NachoSoto) * `Offline Entitlements`: allow creating offline `CustomerInfo` with empty `ProductEntitlementMapping` (#2504) via NachoSoto (@NachoSoto) * `Offline Entitlements`: integration tests (#2501) via NachoSoto (@NachoSoto) * `CustomerInfoManager`: don't cache offline `CustomerInfo` (#2378) via NachoSoto (@NachoSoto) * `DangerousSettings`: debug-only `forceServerErrors` (#2486) via NachoSoto (@NachoSoto) * `CocoapodsInstallation`: fixed `Xcode 14.3.0` issue (#2489) via NachoSoto (@NachoSoto) * `CarthageInstallation`: removed workaround (#2488) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>

NachoSoto added the refactor label May 22, 2023

NachoSoto requested a review from a team May 22, 2023 20:04

tonidero reviewed May 23, 2023

View reviewed changes

Base automatically changed from product-fetcher-sync-appstore to main May 23, 2023 16:05

NachoSoto force-pushed the nacho/sdk-3030-test-consumables branch from 85fe2ae to cf79196 Compare May 23, 2023 17:03

NachoSoto requested review from tonidero and aboedo May 23, 2023 17:29

NachoSoto force-pushed the nacho/sdk-3030-test-consumables branch from 8f70b75 to a55721e Compare May 23, 2023 17:30

NachoSoto changed the title ~~Offline Entitlements: don't compute offline CustomerInfo when purchasing a consumable product~~ Offline Entitlements: don't compute offline CustomerInfo when purchasing a consumable products May 23, 2023

tonidero approved these changes May 24, 2023

View reviewed changes

NachoSoto and others added 8 commits May 24, 2023 11:56

Generating new test snapshots for nacho/sdk-3030-test-consumables -…

5254eb2

… ios-15 (#2523)

Generating new test snapshots for nacho/sdk-3030-test-consumables -…

929aac7

… ios-14 (#2524)

Removed old snapshots

e33bc8b

Moved check to PurchasedProductsFetcher

3184abf

NachoSoto force-pushed the nacho/sdk-3030-test-consumables branch from a55721e to 3184abf Compare May 24, 2023 19:15

NachoSoto enabled auto-merge (squash) May 24, 2023 19:15

NachoSoto merged commit edc0f6b into main May 24, 2023

NachoSoto deleted the nacho/sdk-3030-test-consumables branch May 24, 2023 19:33

This was referenced May 31, 2023

[AUTOMATIC] Release/4.21.0 #2569

Closed

[AUTOMATIC] Release/4.21.0 #2571

Merged

NachoSoto mentioned this pull request May 31, 2023

Release/4.20.1 #2572

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products #2522

`Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products #2522

NachoSoto commented May 22, 2023 •

edited

Loading

NachoSoto commented May 22, 2023 •

edited

Loading

codecov bot commented May 22, 2023 •

edited

Loading

tonidero May 23, 2023

NachoSoto May 23, 2023

tonidero left a comment

tonidero May 24, 2023

NachoSoto May 24, 2023

NachoSoto May 24, 2023

tonidero May 24, 2023

NachoSoto May 24, 2023

Offline Entitlements: don't compute offline CustomerInfo when purchasing a consumable products #2522

Offline Entitlements: don't compute offline CustomerInfo when purchasing a consumable products #2522

Conversation

NachoSoto commented May 22, 2023 • edited Loading

Changes:

NachoSoto commented May 22, 2023 • edited Loading

codecov bot commented May 22, 2023 • edited Loading

Codecov Report

tonidero May 23, 2023

Choose a reason for hiding this comment

NachoSoto May 23, 2023

Choose a reason for hiding this comment

tonidero left a comment

Choose a reason for hiding this comment

tonidero May 24, 2023

Choose a reason for hiding this comment

NachoSoto May 24, 2023

Choose a reason for hiding this comment

NachoSoto May 24, 2023

Choose a reason for hiding this comment

tonidero May 24, 2023

Choose a reason for hiding this comment

NachoSoto May 24, 2023

Choose a reason for hiding this comment

`Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products #2522

`Offline Entitlements`: don't compute offline `CustomerInfo` when purchasing a consumable products #2522

NachoSoto commented May 22, 2023 •

edited

Loading

NachoSoto commented May 22, 2023 •

edited

Loading

codecov bot commented May 22, 2023 •

edited

Loading