Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 15: handle Locale.currencyCode deprecation #2680

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

NachoSoto
Copy link
Contributor

This is required to compile for xrOS.

@NachoSoto NachoSoto requested a review from a team June 21, 2023 21:32
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2680 (97dd465) into main (7298dfa) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
- Coverage   86.56%   86.53%   -0.04%     
==========================================
  Files         208      209       +1     
  Lines       14801    14813      +12     
==========================================
+ Hits        12813    12818       +5     
- Misses       1988     1995       +7     
Impacted Files Coverage Δ
...urces/FoundationExtensions/Locale+Extensions.swift 100.00% <100.00%> (ø)
...chasing/StoreKitAbstractions/SK1StoreProduct.swift 92.30% <100.00%> (-5.77%) ⬇️
...StoreKitAbstractions/SK1StoreProductDiscount.swift 92.85% <100.00%> (ø)

... and 2 files with indirect coverage changes

@NachoSoto NachoSoto merged commit 6d60af2 into main Jun 22, 2023
@NachoSoto NachoSoto deleted the xros-locale branch June 22, 2023 13:23
NachoSoto added a commit that referenced this pull request Jun 22, 2023
### Dependencies:

- #2680
- #2681
- #2683

### Future changes:
- [x] Enable for `PurchaseTester`: #2685
- [ ] Build this target in `CI`
- [ ] Run tests on `xrOS`
NachoSoto pushed a commit that referenced this pull request Jun 22, 2023
**This is an automatic release.**

_This release is compatible with `Xcode 15 beta 2` and `visionOS beta
1`_

### New Features
* `xrOS`: added to list of supported platforms (#2682) via NachoSoto
(@NachoSoto)
### Bugfixes
* `xrOS`: fixed compilation by disabling debug overlay (#2681) via
NachoSoto (@NachoSoto)
* `xrOS`: added support for new `purchase(confirmIn:options:)` method
(#2683) via NachoSoto (@NachoSoto)
* `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via
NachoSoto (@NachoSoto)
### Other Changes
* `PurchaseTester`: fixed release compilation (#2689) via NachoSoto
(@NachoSoto)
* `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto)
* `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto
(@NachoSoto)
* `Signature Verification`: new `Integration Tests` (#2642) via
NachoSoto (@NachoSoto)
* `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors
(#2686) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants