xrOS: added support for new purchase(confirmIn:options:) method
#2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Jun 21, 2023
NachoSoto
force-pushed
the
xros-purchase-scene
branch
from
ce72303
to
4e24085
Compare
3 tasks
NachoSoto
added a commit
that referenced
this pull request
Jun 21, 2023
If we end up calling these methods with an existing `PurchasesError`, we'd end up creating an `.unknownError` instead of returning that. This is actually needed for #2683, where the inside of the `do`/`catch` can throw a `PurchasesError`.
NachoSoto
force-pushed
the
xros-purchase-scene
branch
2 times, most recently
from
ab62739
to
9d5585e
Compare
NachoSoto
commented
Jun 21, 2023
Comment on lines
462
to
463
| result = try await sk2Product.purchase(confirmIn: try self.systemInfo.currentWindowScene, | ||
| options: options) |
There was a problem hiding this comment.
This needs #2686 to make sure we throw the correct error.
NachoSoto
force-pushed
the
xros-purchase-scene
branch
2 times, most recently
from
1d943fe
to
d5e19a9
Compare
NachoSoto
force-pushed
the
xros-purchase-scene
branch
from
d5e19a9
to
ed69013
Compare
NachoSoto
commented
Jun 22, 2023
Comment on lines
+509
to
+510
| // Note: this can be simplified as `#if swift(>=5.9) && os(xrOS)` | ||
| // once we drop support for Xcode 13.x |
There was a problem hiding this comment.
Short-circuiting doesn't work in Xcode 13: https://twitter.com/nachosoto/status/1671666952773971968?s=61&t=eV60wxp04gdupmhWzuBI1g
There was a problem hiding this comment.
This is the answer to your other question @tonidero @MarkVillacampa, I just didn’t want to duplicate this comment everywhere.
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
=======================================
Coverage 86.56% 86.57%
=======================================
Files 208 208
Lines 14801 14818 +17
=======================================
+ Hits 12813 12829 +16
- Misses 1988 1989 +1
|
MarkVillacampa
approved these changes
Jun 22, 2023
|
Confirmed this works :) |
NachoSoto
added a commit
that referenced
this pull request
Jun 22, 2023
This was missing in #2683, these methods need to be invoked from the `@MainActor`.
NachoSoto
added a commit
that referenced
this pull request
Jun 22, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Jun 22, 2023
**This is an automatic release.** _This release is compatible with `Xcode 15 beta 2` and `visionOS beta 1`_ ### New Features * `xrOS`: added to list of supported platforms (#2682) via NachoSoto (@NachoSoto) ### Bugfixes * `xrOS`: fixed compilation by disabling debug overlay (#2681) via NachoSoto (@NachoSoto) * `xrOS`: added support for new `purchase(confirmIn:options:)` method (#2683) via NachoSoto (@NachoSoto) * `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: fixed release compilation (#2689) via NachoSoto (@NachoSoto) * `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto) * `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto (@NachoSoto) * `Signature Verification`: new `Integration Tests` (#2642) via NachoSoto (@NachoSoto) * `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors (#2686) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.