-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xrOS
: added support to PurchaseTester
#2685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NachoSoto
commented
Jun 21, 2023
•
edited
Loading
edited
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.03%
==========================================
Files 209 208 -1
Lines 14816 14801 -15
==========================================
- Hits 12825 12809 -16
- Misses 1991 1992 +1 |
MarkVillacampa
approved these changes
Jun 22, 2023
tonidero
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
NachoSoto
force-pushed
the
xros-purchase-tester
branch
from
June 22, 2023 14:35
b4f9909
to
d7d3f3f
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Jun 22, 2023
**This is an automatic release.** _This release is compatible with `Xcode 15 beta 2` and `visionOS beta 1`_ ### New Features * `xrOS`: added to list of supported platforms (#2682) via NachoSoto (@NachoSoto) ### Bugfixes * `xrOS`: fixed compilation by disabling debug overlay (#2681) via NachoSoto (@NachoSoto) * `xrOS`: added support for new `purchase(confirmIn:options:)` method (#2683) via NachoSoto (@NachoSoto) * `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: fixed release compilation (#2689) via NachoSoto (@NachoSoto) * `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto) * `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto (@NachoSoto) * `Signature Verification`: new `Integration Tests` (#2642) via NachoSoto (@NachoSoto) * `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors (#2686) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jun 23, 2023
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/12159/workflows/89db4b5d-bafc-4b99-ac86-4f205e49f1bf/jobs/81368 We were not correctly embedding (and therefore building) the `watchOS` extension until #2685. That exposed a bunch of other issues which this fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.