Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrOS: added support to PurchaseTester #2685

Merged
merged 1 commit into from
Jun 22, 2023
Merged

xrOS: added support to PurchaseTester #2685

merged 1 commit into from
Jun 22, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jun 21, 2023

image
image

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2685 (b4f9909) into main (7a07b3f) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b4f9909 differs from pull request most recent head d7d3f3f. Consider uploading reports for the commit d7d3f3f to get more accurate results

@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   86.56%   86.54%   -0.03%     
==========================================
  Files         209      208       -1     
  Lines       14816    14801      -15     
==========================================
- Hits        12825    12809      -16     
- Misses       1991     1992       +1     

see 2 files with indirect coverage changes

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@NachoSoto NachoSoto enabled auto-merge (squash) June 22, 2023 14:36
@NachoSoto NachoSoto merged commit 7dc9e90 into main Jun 22, 2023
@NachoSoto NachoSoto deleted the xros-purchase-tester branch June 22, 2023 14:49
NachoSoto added a commit that referenced this pull request Jun 22, 2023
### Dependencies:

- #2680
- #2681
- #2683

### Future changes:
- [x] Enable for `PurchaseTester`: #2685
- [ ] Build this target in `CI`
- [ ] Run tests on `xrOS`
NachoSoto pushed a commit that referenced this pull request Jun 22, 2023
**This is an automatic release.**

_This release is compatible with `Xcode 15 beta 2` and `visionOS beta
1`_

### New Features
* `xrOS`: added to list of supported platforms (#2682) via NachoSoto
(@NachoSoto)
### Bugfixes
* `xrOS`: fixed compilation by disabling debug overlay (#2681) via
NachoSoto (@NachoSoto)
* `xrOS`: added support for new `purchase(confirmIn:options:)` method
(#2683) via NachoSoto (@NachoSoto)
* `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via
NachoSoto (@NachoSoto)
### Other Changes
* `PurchaseTester`: fixed release compilation (#2689) via NachoSoto
(@NachoSoto)
* `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto)
* `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto
(@NachoSoto)
* `Signature Verification`: new `Integration Tests` (#2642) via
NachoSoto (@NachoSoto)
* `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors
(#2686) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Jun 23, 2023
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/12159/workflows/89db4b5d-bafc-4b99-ac86-4f205e49f1bf/jobs/81368

We were not correctly embedding (and therefore building) the `watchOS` extension until #2685. That exposed a bunch of other issues which this fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants