Implements multioperation for the bitmaps and tree maps #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Clément Renault <clement@meilisearch.com>
irevoire
changed the title
Kerollmops
requested changes
Aug 18, 2022
Kerollmops
requested changes
Aug 18, 2022
Kerollmops
requested changes
Aug 22, 2022
Kerollmops
requested changes
Aug 29, 2022
There was a problem hiding this comment.
This PR is amazing, I love it ❤️
However, would it be possible to publish some simple benchmarks comparison (using critcmp) with the basic reduce-and-collect operations from the past, please?
Co-authored-by: Clément Renault <renault.cle@gmail.com>
Kerollmops
requested changes
Aug 30, 2022
Co-authored-by: Clément Renault <renault.cle@gmail.com>
Kerollmops
requested changes
Aug 30, 2022
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
223: Implements multioperation for the bitmaps and tree maps r=Kerollmops a=irevoire Fixes RoaringBitmap#57, closes RoaringBitmap#58, closes RoaringBitmap#109, closes RoaringBitmap#139, and closes RoaringBitmap#219. There is a lot of performance improvement, but here is a before / after on the operations that were the faster currently (when we can do assign between owned bitmaps). ## And ``` group after before ----- ----- ------ Successive And/Multi And Owned/census-income 1.00 14.6±0.25µs ? ?/sec 15.42 224.9±0.76µs ? ?/sec Successive And/Multi And Owned/census-income_srt 1.00 14.2±0.25µs ? ?/sec 3.98 56.4±8.22µs ? ?/sec Successive And/Multi And Owned/census1881 1.00 20.7±0.33µs ? ?/sec 37.18 770.1±1.62µs ? ?/sec Successive And/Multi And Owned/census1881_srt 1.00 25.8±1.29µs ? ?/sec 1.12 28.8±0.09µs ? ?/sec Successive And/Multi And Owned/weather_sept_85 1.00 60.7±2.48µs ? ?/sec 2.15 130.2±2.96µs ? ?/sec Successive And/Multi And Owned/weather_sept_85_srt 1.00 48.3±2.21µs ? ?/sec 2.32 112.2±1.07µs ? ?/sec Successive And/Multi And Owned/wikileaks-noquotes 1.00 24.4±0.50µs ? ?/sec 2.73 66.6±0.27µs ? ?/sec Successive And/Multi And Owned/wikileaks-noquotes_srt 1.00 20.3±0.58µs ? ?/sec 1.09 22.0±0.30µs ? ?/sec ``` ## Or ``` group after before ----- ----- ------ Successive Or/Multi Or Owned/census-income 1.00 629.3±4.46µs ? ?/sec 2.29 1441.4±41.36µs ? ?/sec Successive Or/Multi Or Owned/census-income_srt 1.00 582.5±1.81µs ? ?/sec 1.61 937.8±4.03µs ? ?/sec Successive Or/Multi Or Owned/census1881 1.00 1143.4±4.55µs ? ?/sec 3.48 4.0±0.07ms ? ?/sec Successive Or/Multi Or Owned/census1881_srt 1.00 743.4±4.40µs ? ?/sec 3.49 2.6±0.02ms ? ?/sec Successive Or/Multi Or Owned/weather_sept_85 1.00 2.9±0.02ms ? ?/sec 1.06 3.1±0.01ms ? ?/sec Successive Or/Multi Or Owned/weather_sept_85_srt 1.00 1344.5±7.80µs ? ?/sec 1.06 1426.5±38.08µs ? ?/sec Successive Or/Multi Or Owned/wikileaks-noquotes 1.00 476.3±4.43µs ? ?/sec 5.27 2.5±0.01ms ? ?/sec Successive Or/Multi Or Owned/wikileaks-noquotes_srt 1.00 259.4±3.90µs ? ?/sec 7.17 1860.0±3.30µs ? ?/sec ``` Co-authored-by: saik0 <github@saik0.net> Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Irevoire <tamo@meilisearch.com> Co-authored-by: Tamo <irevoire@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57, closes #58, closes #109, closes #139, and closes #219.
There is a lot of performance improvement, but here is a before / after on the operations that were the faster currently (when we can do assign between owned bitmaps).
And
Or