Skip to content

Commit

Permalink
[lint] Tidy up genquery input (#18253)
Browse files Browse the repository at this point in the history
Our genquery scope opts-in to the //foo/bar:bar library spelling, not
the //foo/bar abbreviation; this is flagged as an error in Bazel 6.0.
Use the //foo/bar:bar spelling to avoid the error.
  • Loading branch information
jwnimmer-tri authored Nov 3, 2022
1 parent b23faa4 commit 99d7aef
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/lint/library_lint.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def library_lint(

# Find libraries that are deps of the package_library but shouldn't be.
extra_deps_expression = "deps({}, 1) except ({}) except {}".format(
package_name,
package_name + ":" + short_package_name,
correct_deps_expression,
# This is fine (it's a dependency of our copt select() statement).
"//tools:drake_werror",
Expand All @@ -107,7 +107,7 @@ def library_lint(
# positives from this report.
missing_deps_expression = "({}) except deps({}, 1) ".format(
correct_deps_expression,
package_name,
package_name + ":" + short_package_name,
)

# If there was a package_library rule, ensure its deps are comprehensive.
Expand Down

0 comments on commit 99d7aef

Please sign in to comment.