[lint] Tidy up genquery input #18253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our genquery scope opts-in to the //foo/bar:bar library spelling, not the //foo/bar abbreviation; this is flagged as an error in Bazel 6.0. Use the //foo/bar:bar spelling to avoid the error.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@EricCousineau-TRI for both reviews per schedule, please. |
There was a problem hiding this comment.
Label class
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/lint/library_lint.bzl line 99 at r1 (raw file):
# Find libraries that are deps of the package_library but shouldn't be. extra_deps_expression = "deps({}, 1) except ({}) except {}".format( package_name + ":" + short_package_name,
BTW In future, consider using Label:
https://bazel.build/rules/lib/Label
Example usage: bazelbuild/bazel-skylib#393
xuchenhan-tri
pushed a commit
to xuchenhan-tri/drake
that referenced
this pull request
Feb 6, 2023
Our genquery scope opts-in to the //foo/bar:bar library spelling, not the //foo/bar abbreviation; this is flagged as an error in Bazel 6.0. Use the //foo/bar:bar spelling to avoid the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our genquery scope opts-in to the
//foo/bar:barlibrary spelling, not the//foo/barabbreviation; this is flagged as an error in Bazel 6.0. Use the//foo/bar:barspelling to avoid the error.Example failure prior to this PR here.
Example success with this PR here.
This change is