[solvers] Add CommonSolverOption::to_string #22079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: medium
release notes: newly deprecated
jwnimmer-tri
changed the title
jwnimmer-tri
force-pushed
the
solver-options-common-to_string
branch
2 times, most recently
from
161fcf1 to
7ceac57
Compare
jwnimmer-tri
added
the
status: single reviewer ok
|
+@xuchenhan-tri for both reviews, please (I'm on-call Monday). |
Deprecate operator<<.
jwnimmer-tri
force-pushed
the
solver-options-common-to_string
branch
from
7ceac57 to
7e97524
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
Deprecate operator<<.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
operator<<. I'm using a 6-month window since the deprecations for #22078 might be intrusive, and it's not that costly to keep around the shims a little extra while.Towards #22078. Efficient string look-up of common option names is important for that feature.
This change is