[solvers] Reflow option classes' comments to my preferred style #22101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
status: single reviewer ok
|
+@hongkai-dai for general feature review, please. It's OK if you want to leave the detailed read-thru to the platform reviewer, mostly just seeking any big-picture input. |
hongkai-dai
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),hongkai-dai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22078. In that PR, I am fixing / heavily editing a lot of this text, and I don't want to mix these formatting changes in with the actually-meaningful edits.
This change is