Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Displays Nothing found on admin sidebar when search returns nothing #16255

Merged
merged 1 commit into from
Mar 11, 2020
Merged

[IMPROVE] Displays Nothing found on admin sidebar when search returns nothing #16255

merged 1 commit into from
Mar 11, 2020

Conversation

ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Jan 15, 2020 •
edited
Loading

Closes #16091

Before changes:

adminaccserch

After changes:

adminsearch

@ashwaniYDV ashwaniYDV changed the title No settings are displayed if search not found [FIX] No settings are displayed if search not found Jan 15, 2020
@ashwaniYDV ashwaniYDV changed the title [FIX] No settings are displayed if search not found [FIX] No settings to be displayed if search not found Jan 15, 2020
@ashwaniYDV ashwaniYDV requested a review from gabriellsh February 5, 2020 20:58
@claassistantio
Copy link

claassistantio commented Feb 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego merged commit 1857240 into RocketChat:develop Mar 11, 2020
gabriellsh added a commit to ritwizsinha/Rocket.Chat that referenced this pull request Mar 11, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
149a904 
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (173 commits)
  [FIX] No settings to be displayed if search not found (RocketChat#16255)
  [FIX] Removed some hardcoded texts (RocketChat#16304)
  [FIX] Cannot unfollow message from thread's panel (RocketChat#16560)
  Add Enterprise Edition license (RocketChat#16801)
  [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (RocketChat#16776)
  [IMPROVE] Apps-engine E2E tests (RocketChat#16781)
  [FIX] Remove spaces from i18n placeholders to show Personal access token (RocketChat#16724)
  [NEW] SAML config to allow clock drift (RocketChat#16751)
  [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (RocketChat#16750)
  [FIX] Cannot pin on direct messages (RocketChat#16759)
  [FIX] Get all channels from Slack via REST API (RocketChat#16767)
  LingoHub Update 🚀 (RocketChat#16837)
  [FIX]  Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (RocketChat#16797)
  Update Node to 12.16.1
  [NEW] Update Meteor to 1.9.2 (RocketChat#16718)
  [FIX] Slackbridge-import command doesn't work (RocketChat#16645)
  Fix omnichannel icon missing on sidebar (RocketChat#16775)
  [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752)
  [FIX] Language country has been ignored on translation load (RocketChat#16757)
  [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744)
  ...
gabriellsh added a commit that referenced this pull request Mar 13, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
f702691 
…exact_search

* 'develop' of github.com:RocketChat/Rocket.Chat: (178 commits)
  [IMPROVE] Add option to require authentication on user's shield endpoint (#16845)
  [FIX] Custom OAuth Bug (#16811)
  [FIX] Integrations page pagination (#16838)
  fix: livechat/facebook missing visitor data after registerGuest (#16810)
  [FIX] Invite links counting users already joined (#16591)
  [FIX] No settings to be displayed if search not found (#16255)
  [FIX] Removed some hardcoded texts (#16304)
  [FIX] Cannot unfollow message from thread's panel (#16560)
  Add Enterprise Edition license (#16801)
  [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (#16776)
  [IMPROVE] Apps-engine E2E tests (#16781)
  [FIX] Remove spaces from i18n placeholders to show Personal access token (#16724)
  [NEW] SAML config to allow clock drift (#16751)
  [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (#16750)
  [FIX] Cannot pin on direct messages (#16759)
  [FIX] Get all channels from Slack via REST API (#16767)
  LingoHub Update 🚀 (#16837)
  [FIX]  Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (#16797)
  Update Node to 12.16.1
  [NEW] Update Meteor to 1.9.2 (#16718)
  ...
@rodrigok rodrigok changed the title [FIX] No settings to be displayed if search not found [IMPROVE] Displays Nothing found on admin sidebar when search returns nothing Mar 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

@zdumitru zdumitru zdumitru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The search in administration setting shows all settings when no settings found
5 participants
@ashwaniYDV @claassistantio @zdumitru @gabriellsh @sampaiodiego