Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix omnichannel icon missing on sidebar #16775

Merged

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Mar 3, 2020

Some resources were renamed from "livechat" to "omnichannel" in this PR, but the icone name had not been renamed in the Livechat RoomType.

Before:
Screen Shot 2020-03-03 at 10 31 30

After:
Screen Shot 2020-03-03 at 10 47 48

@renatobecker renatobecker added this to the 3.1.0 milestone Mar 3, 2020
@sampaiodiego sampaiodiego changed the title [FIX] Omnichannel icon missing on sidebar Regression: Fix omnichannel icon missing on sidebar Mar 3, 2020
@renatobecker renatobecker merged commit e9890aa into develop Mar 3, 2020
@renatobecker renatobecker deleted the omnichannel/fix-omnichannel-icon-missing-sidebar branch March 3, 2020 14:18
gabriellsh added a commit to Pranav2612000/Rocket.Chat that referenced this pull request Mar 3, 2020
…6643-Pranav2612000-develop

* 'develop' of github.com:RocketChat/Rocket.Chat: (71 commits)
  Fix omnichannel icon missing on sidebar (RocketChat#16775)
  [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752)
  [FIX] Language country has been ignored on translation load (RocketChat#16757)
  [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744)
  [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502)
  Removing Trailing Space (RocketChat#16470)
  Lazy load categories and marketplaceVersion (RocketChat#16258)
  Fix Docker preview image (RocketChat#16736)
  [FIX] Manual Register use correct state for determining registered (RocketChat#16726)
  [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723)
  [CHORE] Changed remaining SelectInput's to Select (RocketChat#16719)
  [CHORE] Update snap install instructions (RocketChat#16720)
  [FIX] TypeError when trying to load avatar of an invalid room. (RocketChat#16699)
  [FIX] Color setting editing issues (RocketChat#16706)
  [FIX] Console error on login (RocketChat#16704)
  [NEW] Add methods to include room types on dashboard (RocketChat#16576)
  [FIX] ie11 support (RocketChat#16682)
  Regression: Show upload errors (RocketChat#16681)
  [FIX] Delete messages while searching bug (RocketChat#16568)
  Use insertSync
  ...
gabriellsh added a commit to ritwizsinha/Rocket.Chat that referenced this pull request Mar 11, 2020
…6537-ritwizsinha-Issue#16499

* 'develop' of github.com:RocketChat/Rocket.Chat: (173 commits)
  [FIX] No settings to be displayed if search not found (RocketChat#16255)
  [FIX] Removed some hardcoded texts (RocketChat#16304)
  [FIX] Cannot unfollow message from thread's panel (RocketChat#16560)
  Add Enterprise Edition license (RocketChat#16801)
  [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (RocketChat#16776)
  [IMPROVE] Apps-engine E2E tests (RocketChat#16781)
  [FIX] Remove spaces from i18n placeholders to show Personal access token (RocketChat#16724)
  [NEW] SAML config to allow clock drift (RocketChat#16751)
  [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (RocketChat#16750)
  [FIX] Cannot pin on direct messages (RocketChat#16759)
  [FIX] Get all channels from Slack via REST API (RocketChat#16767)
  LingoHub Update 🚀 (RocketChat#16837)
  [FIX]  Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (RocketChat#16797)
  Update Node to 12.16.1
  [NEW] Update Meteor to 1.9.2 (RocketChat#16718)
  [FIX] Slackbridge-import command doesn't work (RocketChat#16645)
  Fix omnichannel icon missing on sidebar (RocketChat#16775)
  [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752)
  [FIX] Language country has been ignored on translation load (RocketChat#16757)
  [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants