[FIX] Deleting messages while searching causes the whole room chat to disappear #16568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ggazzo
changed the title
ggazzo
approved these changes
Feb 21, 2020
gabriellsh
added a commit
that referenced
this pull request
Feb 21, 2020
…use_scrollableArea * 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) [FIX] ie11 support (#16682) Regression: Show upload errors (#16681) [FIX] Delete messages while searching bug (#16568) Use insertSync [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (#16416) [FIX] Added an option to pin/unpin a thread message by admin (#16457) [CHORE] Look for Storybook stories on `app/` too (#16595) [IMPROVE] Removed the 'reply in thread' from thread replies (#16630) [FIX] Changed Opt_In message (#16631) [FIX] LDAP sync admin action was not syncing exisent users (#16671) [IMPROVE] Check agent status when starting a new conversation with an agent assigned (#16618) [FIX] Additional scroll when contextual bar is open (#16667) [FIX] Clear unread red line when the ESC key is pressed (#16668) [FIX] users.info endpoint not handling the error if the user does not exist (#16495) [NEW] Save default filters in the Omnichannel Current Chats list (#16653) Update app/utils/client/lib/RestApiClient.js Update app/utils/client/lib/RestApiClient.js send files over rest api [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot Improved isSingular function ...
gabriellsh
added a commit
to subham103/Rocket.Chat
that referenced
this pull request
Feb 21, 2020
…6680-subham103-fixMessageCountStatistics * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] ie11 support (RocketChat#16682) Regression: Show upload errors (RocketChat#16681) [FIX] Delete messages while searching bug (RocketChat#16568) Use insertSync [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (RocketChat#16416) [FIX] Added an option to pin/unpin a thread message by admin (RocketChat#16457) [CHORE] Look for Storybook stories on `app/` too (RocketChat#16595) [IMPROVE] Removed the 'reply in thread' from thread replies (RocketChat#16630) [FIX] Changed Opt_In message (RocketChat#16631) [FIX] LDAP sync admin action was not syncing exisent users (RocketChat#16671) [IMPROVE] Check agent status when starting a new conversation with an agent assigned (RocketChat#16618) [FIX] Additional scroll when contextual bar is open (RocketChat#16667) [FIX] Clear unread red line when the ESC key is pressed (RocketChat#16668) [FIX] users.info endpoint not handling the error if the user does not exist (RocketChat#16495) Update app/utils/client/lib/RestApiClient.js Update app/utils/client/lib/RestApiClient.js send files over rest api [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot Improved isSingular function Add message_pruned and file_pruned for singular file or message deleted ...
gabriellsh
added a commit
to Pranav2612000/Rocket.Chat
that referenced
this pull request
Mar 3, 2020
…6643-Pranav2612000-develop * 'develop' of github.com:RocketChat/Rocket.Chat: (71 commits) Fix omnichannel icon missing on sidebar (RocketChat#16775) [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752) [FIX] Language country has been ignored on translation load (RocketChat#16757) [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744) [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502) Removing Trailing Space (RocketChat#16470) Lazy load categories and marketplaceVersion (RocketChat#16258) Fix Docker preview image (RocketChat#16736) [FIX] Manual Register use correct state for determining registered (RocketChat#16726) [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723) [CHORE] Changed remaining SelectInput's to Select (RocketChat#16719) [CHORE] Update snap install instructions (RocketChat#16720) [FIX] TypeError when trying to load avatar of an invalid room. (RocketChat#16699) [FIX] Color setting editing issues (RocketChat#16706) [FIX] Console error on login (RocketChat#16704) [NEW] Add methods to include room types on dashboard (RocketChat#16576) [FIX] ie11 support (RocketChat#16682) Regression: Show upload errors (RocketChat#16681) [FIX] Delete messages while searching bug (RocketChat#16568) Use insertSync ...
rodrigok
changed the title
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16413
From what I understand, it try to finds the message in the room if not it fetches it deletes it and fetches it again from the backend and search for specific message.
so what i did i made the deletion part after we fetch it from the backend to make sure not to delete the whole chat.