Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Manual Register use correct state for determining registered #16726

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

geekgonecrazy
Copy link
Contributor

Right now uses connectToCloud which is purely the intent to register not if its already registered

d-gubert
d-gubert previously approved these changes Feb 27, 2020
@geekgonecrazy geekgonecrazy changed the title [FIX] Manual Register api call not working [FIX] Manual Register use correct state to show button Feb 27, 2020
@geekgonecrazy geekgonecrazy changed the title [FIX] Manual Register use correct state to show button [FIX] Manual Register use correct state for determining registered Feb 27, 2020
@geekgonecrazy
Copy link
Contributor Author

Sweet you found the loose --> 😁

@d-gubert d-gubert merged commit 6f0e929 into develop Feb 27, 2020
@d-gubert d-gubert deleted the fix-manual-register branch February 27, 2020 18:26
gabriellsh added a commit to AgentTNT/Rocket.Chat that referenced this pull request Feb 28, 2020
…6728-TheGr8Wonder-prune-granular

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Fix Docker preview image (RocketChat#16736)
  [FIX] Manual Register use correct state for determining registered (RocketChat#16726)
  [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723)
@sampaiodiego sampaiodiego added this to the 3.0.3 milestone Mar 2, 2020
sampaiodiego pushed a commit that referenced this pull request Mar 2, 2020
…16726)

* Fix: Manual Register api call

* show button using correct condition

* Removed '-->' from modal

Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
@sampaiodiego sampaiodiego mentioned this pull request Mar 2, 2020
gabriellsh added a commit to Pranav2612000/Rocket.Chat that referenced this pull request Mar 3, 2020
…6643-Pranav2612000-develop

* 'develop' of github.com:RocketChat/Rocket.Chat: (71 commits)
  Fix omnichannel icon missing on sidebar (RocketChat#16775)
  [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752)
  [FIX] Language country has been ignored on translation load (RocketChat#16757)
  [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744)
  [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502)
  Removing Trailing Space (RocketChat#16470)
  Lazy load categories and marketplaceVersion (RocketChat#16258)
  Fix Docker preview image (RocketChat#16736)
  [FIX] Manual Register use correct state for determining registered (RocketChat#16726)
  [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723)
  [CHORE] Changed remaining SelectInput's to Select (RocketChat#16719)
  [CHORE] Update snap install instructions (RocketChat#16720)
  [FIX] TypeError when trying to load avatar of an invalid room. (RocketChat#16699)
  [FIX] Color setting editing issues (RocketChat#16706)
  [FIX] Console error on login (RocketChat#16704)
  [NEW] Add methods to include room types on dashboard (RocketChat#16576)
  [FIX] ie11 support (RocketChat#16682)
  Regression: Show upload errors (RocketChat#16681)
  [FIX] Delete messages while searching bug (RocketChat#16568)
  Use insertSync
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants