Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Direct message between multiple users #16761

Merged
merged 83 commits into from
Mar 26, 2020
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 1, 2020

Giving the proper credits for those who did the first step to get this feature done:

@gnidorah
@zdumitru
@slegare

Based on #9106
Depends on #16753
Closes #4489

Current state

image
image

Still missing:

Frontend

  • Room Info
  • Edit update Group Icon
  • Properly Description
  • Properly modal to open/invite users
  • Deal with avatars
  • Deal with presence

Backend

  • Update fname if the user changes the name
  • Deal with user deletion
  • Stop/Remove rid based on user id join
  • Check Rocketchat apps events
  • Check Federation callback with more users

Docs

  • Edit docs - createDirectMessage
  • Edit docs - explain "new feature"

@ggazzo ggazzo requested a review from sampaiodiego March 1, 2020 01:04
@ggazzo ggazzo added this to the 4.0.0 milestone Mar 1, 2020
@tassoevan tassoevan self-requested a review March 2, 2020 05:46
ggazzo added 3 commits March 2, 2020 10:06
… into dm/multiple-users

* 'dm/multiple-users' of github.com:RocketChat/Rocket.Chat:
  Update openRoom.js
@ggazzo ggazzo force-pushed the dm/multiple-users branch from 1318426 to b845c7c Compare March 2, 2020 18:53
@ggazzo ggazzo modified the milestones: 4.0.0, 3.1.0 Mar 2, 2020
@ggazzo ggazzo changed the title [WIP][NEW] Dm/multiple users [WIP][NEW] Direct message between multiple users Mar 17, 2020
@ggazzo ggazzo force-pushed the dm/multiple-users branch from 4309ccb to a0bae6a Compare March 24, 2020 15:58
@ggazzo ggazzo changed the title [WIP][NEW] Direct message between multiple users [NEW] Direct message between multiple users Mar 24, 2020
app/ui/client/views/app/CreateDirectMessage.js Outdated Show resolved Hide resolved
server/publications/room/index.js Outdated Show resolved Hide resolved
sampaiodiego and others added 9 commits March 25, 2020 18:23
…ultiple-users

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [NEW] Engagement Dashboard (#16960)
  Fix StreamCast info (#16995)
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
… into dm/multiple-users

* 'dm/multiple-users' of github.com:RocketChat/Rocket.Chat:
  Rename field on Apps Engine uids -> userIds
  Code style
  Add support to group DMs to Apps engine
sampaiodiego
sampaiodiego previously approved these changes Mar 25, 2020
@sampaiodiego
Copy link
Member

sampaiodiego commented Mar 26, 2020

Added credits for the amazing work on #9106 to

@gnidorah
@zdumitru
@slegare

@sampaiodiego sampaiodiego merged commit 3e1fdbd into develop Mar 26, 2020
@sampaiodiego sampaiodiego deleted the dm/multiple-users branch March 26, 2020 03:24
gabriellsh added a commit that referenced this pull request Mar 26, 2020
…/react-root

* 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits)
  Regression: Fix issue with opening rooms (#17028)
  Group DM improvements
  [NEW] Sort channel directory listing by latest message (#16604)
  [FIX] Wrong message count statistics in Admin info page (#16680)
  Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998)
  [NEW] Direct message between multiple users (#16761)
  Bump version to 3.0.7
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Bump version to 3.0.6
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [FIX]  Keeps the agent in the room after accepting a new Omnichannel request (#16787)
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [NEW] Engagement Dashboard (#16960)
  Fix StreamCast info (#16995)
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
  Bump version to 3.0.5
  [FIX] Race conditions on/before login (#16989)
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct Messages Between Multiple Users
3 participants