Regression: Replace the Omnichannel queue model observe with Stream #16999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
changed the title
rodrigok
previously approved these changes
Mar 25, 2020
rodrigok
approved these changes
Mar 25, 2020
ggazzo
changed the title
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 25, 2020
…16999) * Replace LivechatInquiry observe by stream. * Unify stream. * Add hasPermission method. * Add missing importers. * Revert package-lock file. * Improve the codebase. * Add return statement. * Fix remove listeners that were missing. * Removed unnecessary imports. * Remove unnecessary function parameters.
Merged
ggazzo
added a commit
that referenced
this pull request
Mar 25, 2020
…ultiple-users * 'develop' of github.com:RocketChat/Rocket.Chat: [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [NEW] Engagement Dashboard (#16960) Fix StreamCast info (#16995) [IMPROVE] Ability to change offline message button link on emails notifications (#16784) [FIX] Race conditions on/before login (#16989) Fix: StreamCast was not working correctly (#16983)
gabriellsh
added a commit
that referenced
this pull request
Mar 26, 2020
…/react-root * 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits) Regression: Fix issue with opening rooms (#17028) Group DM improvements [NEW] Sort channel directory listing by latest message (#16604) [FIX] Wrong message count statistics in Admin info page (#16680) Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998) [NEW] Direct message between multiple users (#16761) Bump version to 3.0.7 Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Bump version to 3.0.6 [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [FIX] Keeps the agent in the room after accepting a new Omnichannel request (#16787) [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [NEW] Engagement Dashboard (#16960) Fix StreamCast info (#16995) [IMPROVE] Ability to change offline message button link on emails notifications (#16784) Bump version to 3.0.5 [FIX] Race conditions on/before login (#16989) [FIX] Race conditions on/before login (#16989) Fix: StreamCast was not working correctly (#16983) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Omnichannel queue used by the
Manual Selectionalgorithm was implemented based on the Model observe instead of Stream, which was bringing a bad performance on the server-side.