[NEW] Make the header for rooms clickable #16762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6762-aKn1ghtOut-fix16223 * 'develop' of github.com:RocketChat/Rocket.Chat: (47 commits) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (#16849) [NEW] API to logout from other locations (#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (#16845) [FIX] Custom OAuth Bug (#16811) [FIX] Integrations page pagination (#16838) reset package-lock to upstream Apply suggestions from code review More precision in MS translate API key setting Refactor MS translate: remove redundant code Don't expose translation API keys to client Add missing translation fix: livechat/facebook missing visitor data after registerGuest (#16810) [FIX] Invite links counting users already joined (#16591) [FIX] No settings to be displayed if search not found (#16255) [FIX] Removed some hardcoded texts (#16304) [FIX] Cannot unfollow message from thread's panel (#16560) Add Enterprise Edition license (#16801) [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (#16776) [IMPROVE] Apps-engine E2E tests (#16781) [FIX] Remove spaces from i18n placeholders to show Personal access token (#16724) ...
|
What do you think? @gabriellsh |
gabriellsh
approved these changes
Mar 18, 2020
gabriellsh
changed the title
|
@ggazzo What do you think? |
|
@gabriellsh @rodrigok Anything I should add/edit? |
|
I think it makes sense |
rodrigok
reviewed
Apr 13, 2020
| const $flexTab = $('.flex-tab-container .flex-tab'); | ||
|
|
||
| if (tabBar.getState() === 'opened' && (tabBar.getTemplate() === 'channelSettings' || tabBar.getTemplate() === 'membersList')) { | ||
| $flexTab.attr('template', ''); |
There was a problem hiding this comment.
Is this right setting the html property manually?
There was a problem hiding this comment.
It's been done the same way in flexTabBar.js. I think he got the snippet from there actually.
There was a problem hiding this comment.
That's accurate. I was looking for how it had been implemented, and that's the file I got to.
ggazzo
added a commit
that referenced
this pull request
Apr 20, 2020
…users_and_rooms * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286) [FIX] Spotify embed and collapsed (#17356) Improve: Better Push Notification code (#17338) LingoHub Update 🚀 (#17365) [FIX] Allow Screensharing in BBB Iframe (#17290) [NEW] Make the header for rooms clickable (#16762) Import data pagination (#17355) Allow to set a comment when forwarding omnichannel rooms. (#17353) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249)
dudizilla
added a commit
that referenced
this pull request
Apr 21, 2020
…nto view-logs * 'develop' of https://github.com/RocketChat/Rocket.Chat: [NEW] Allow to send Agent custom fields through the Omnichannel CRM integration (#16286) [FIX] Spotify embed and collapsed (#17356) Improve: Better Push Notification code (#17338) LingoHub Update 🚀 (#17365) [FIX] Allow Screensharing in BBB Iframe (#17290) [NEW] Make the header for rooms clickable (#16762) Import data pagination (#17355) Allow to set a comment when forwarding omnichannel rooms. (#17353) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249) Bump https-proxy-agent from 2.2.1 to 2.2.4 (#17323) [NEW] Adds ability for Rocket.Chat Apps to create discussions (#16683) Add possibility to sort the Omnichannel current chats list by column (#17347) [IMPROVE] Redesign Administration > Import (#17289)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16223
Earlier the title of the rooms wasn't clickable. An event was added to open the Room Info/User Info page when clicked, instead.
Earlier: Title not clickable
Now:
