[NEW][Omnichannel] Ability to set character message limit on Livechat widget #18261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new input for character limit setting
renatobecker
requested changes
Jul 27, 2020
* Adding translation * Changing label to Livechat_message_character_limit * Removing unused function
renatobecker
changed the title
renatobecker
changed the title
renatobecker
requested changes
Jul 28, 2020
renatobecker
requested changes
Jul 29, 2020
There was a problem hiding this comment.
@oguhpereira Rocket.Chat already have a global setting to set the Message character limit for all channels. Since we're implementing a specific setting for Livechat, you need to check the other setting as well and pass its value to the livechat as a fallback configuration.
* adding new option to display character limit * Validating if the limitTextLength is greater than Message_MaxAllowedSizeimport * setting Message_MaxAllowedSizeimport as the default of limitTextLength
|
@renatobecker I added a new option that allows to enable or disable the display of the character limit
It has also been configured so that it fetches the maximum message size setting. The Message Characther Limit field will be used to set a size smaller than the default for the maximum message size setting. |
renatobecker
requested changes
Aug 1, 2020
renatobecker
requested changes
Aug 1, 2020
* Review changes pull-request
* Changing Livechat_show_message_character_limit to Livechat_enable_message_character_limit
* Saving limitTextLength with parseInt
* Adding checkbox options showLimitTextLength
* changing translation showLimitTextLengthFormTrueChecked
|
@renatobecker I changed the review requests but I was in doubt if it was to change the following items:
|
renatobecker
changed the title
renatobecker
approved these changes
Aug 2, 2020
renatobecker
changed the title
gabriellsh
added a commit
that referenced
this pull request
Aug 10, 2020
…omni * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Add REST API endpoint to search Livechat visitors (#18514) LingoHub based on develop (#18516) Update README.md (#18503) [NEW] Channel avatar (#18443) [FIX] Sending notifications from senders without a name (#18479) [FIX] UserCard avatar cache (avatarETag) (#18466) [IMPROVE] Admin Info page requires permission (#18408) [FIX] Marking room as read with unread threads still (#18410) [FIX] Random generated password not matching the Password Policy (#18475) Typo in privacy agreement message (#18476) bugfix for uploading files from livechat (#18474) LingoHub based on develop (#18465) [NEW] Add the ability to set the character message limit on Livechat widget (#18261) [FIX] Migration 194 (#18457) [FIX] Omnichannel session monitor is not starting (#18412) [FIX] Invalid MIME type when uploading audio files (#18426) [FIX] Error when updating omnichannel department without agents parameter (#18428) [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446) [FIX] Multiple push notifications sent via native drivers (#18442) [FIX] Appending 'false' to Jitsi URL (#18430)
dlassalle
reviewed
Aug 19, 2020
| @@ -2168,6 +2170,7 @@ | |||
| "Message_AudioRecorderEnabled_Description": "Requer arquivos 'audio / mp3' para ser um tipo de mídia aceito dentro das configurações 'Upload de arquivo'.", | |||
| "Message_BadWordsFilterList": "Adicione palavrões para a lista negra", | |||
| "Message_BadWordsFilterListDescription": "Adicione palavrões separados por vírgula para filtrar", | |||
| "Message_Characther_Limit": "Limite do caráter da mensagem", | |||
There was a problem hiding this comment.
FYI Characther -> Character, but its the same everywhere for this so it still functions fine
There was a problem hiding this comment.
Thanks, @dlassalle. I'll fix this typo.
rodrigok
changed the title
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implementing a new character limit field in the LiveChat Aparence.
Issue(s)
#17451
How to test or reproduce
If you want test with Livechat, you will need this feature
Screenshots
Types of changes
Checklist
Changelog
additional setting in Admin panel for setting a character limit on livechat.
Further comments