Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Error when reading uploads from Livechat Visitor through the Apps Engine #18474

Merged
merged 2 commits into from
Aug 4, 2020
Merged

[FIX] Error when reading uploads from Livechat Visitor through the Apps Engine #18474

merged 2 commits into from
Aug 4, 2020

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Aug 4, 2020 •
edited by renatobecker
Loading

Proposed changes

Issue(s)

89112123-d713ac00-d434-11ea-9f6b-4031205d0b5d

How to test or reproduce

  1. Upload any file like audio/video as a visitor
  2. Read the uploaded file in an app using IUploadRead

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@renatobecker renatobecker added this to the 3.6.0 milestone Aug 4, 2020
@renatobecker renatobecker mentioned this pull request Aug 4, 2020
Closed
@renatobecker renatobecker changed the title [FIX] Reading uploads from Livechat Visitor in Apps [FIX] Error when reading uploads from Livechat Visitor through the Apps Engine Aug 4, 2020
@renatobecker renatobecker merged commit fc6592e into RocketChat:develop Aug 4, 2020
gabriellsh added a commit that referenced this pull request Aug 10, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ref/…
4013527 
…omni

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Add REST API endpoint to search Livechat visitors (#18514)
  LingoHub based on develop (#18516)
  Update README.md (#18503)
  [NEW] Channel avatar (#18443)
  [FIX] Sending notifications from senders without a name (#18479)
  [FIX] UserCard avatar cache (avatarETag) (#18466)
  [IMPROVE] Admin Info page requires permission (#18408)
  [FIX] Marking room as read with unread threads still (#18410)
  [FIX] Random generated password not matching the Password Policy (#18475)
  Typo in privacy agreement message (#18476)
  bugfix for uploading files from livechat (#18474)
  LingoHub based on develop (#18465)
  [NEW] Add the ability to set the character message limit on Livechat widget (#18261)
  [FIX] Migration 194 (#18457)
  [FIX] Omnichannel session monitor is not starting (#18412)
  [FIX] Invalid MIME type when uploading audio files (#18426)
  [FIX] Error when updating omnichannel department without agents parameter (#18428)
  [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446)
  [FIX] Multiple push notifications sent via native drivers (#18442)
  [FIX] Appending 'false' to Jitsi URL (#18430)
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
@murtaza98 murtaza98 deleted the fix-app-livechat-upload branch August 31, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@murtaza98 @renatobecker