Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Multiple push notifications sent via native drivers #18442

Merged
merged 1 commit into from
Jul 31, 2020
Merged

[FIX] Multiple push notifications sent via native drivers #18442

merged 1 commit into from
Jul 31, 2020

Conversation

sampaiodiego
Copy link
Member

Proposed changes

This actually fixes two things:

  • When sending the same notification to multiple devices, the notification object was being modified to create a payload property as an EJSON, but since this object was a reference, it was being encoded multiple times (for each device sent), so I move the enconding to inside each push notification provider function (APN and GCM) instead of modifying the notification object itself
  • If there was any error with an APN certificate, an error was thrown while instantiating apn.Provider and the server start up was getting stuck, so I added a try/catch to prevent that from hapenning.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego requested a review from rodrigok July 30, 2020 22:14
@sampaiodiego sampaiodiego added this to the 3.5.1 milestone Jul 31, 2020
@djorkaeffalexandre djorkaeffalexandre mentioned this pull request Jul 31, 2020
Closed
@sampaiodiego sampaiodiego merged commit 4ebe528 into develop Jul 31, 2020
@sampaiodiego sampaiodiego deleted the fix-native-notifications branch July 31, 2020 21:05
sampaiodiego added a commit that referenced this pull request Jul 31, 2020
@sampaiodiego
[FIX] Multiple push notifications sent via native drivers (#18442)
bf0b3f7
@sampaiodiego sampaiodiego mentioned this pull request Jul 31, 2020
Merged
sampaiodiego added a commit that referenced this pull request Aug 1, 2020
@sampaiodiego
[FIX] Multiple push notifications sent via native drivers (#18442)
c9ccb78
gabriellsh added a commit that referenced this pull request Aug 10, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ref/…
4013527 
…omni

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Add REST API endpoint to search Livechat visitors (#18514)
  LingoHub based on develop (#18516)
  Update README.md (#18503)
  [NEW] Channel avatar (#18443)
  [FIX] Sending notifications from senders without a name (#18479)
  [FIX] UserCard avatar cache (avatarETag) (#18466)
  [IMPROVE] Admin Info page requires permission (#18408)
  [FIX] Marking room as read with unread threads still (#18410)
  [FIX] Random generated password not matching the Password Policy (#18475)
  Typo in privacy agreement message (#18476)
  bugfix for uploading files from livechat (#18474)
  LingoHub based on develop (#18465)
  [NEW] Add the ability to set the character message limit on Livechat widget (#18261)
  [FIX] Migration 194 (#18457)
  [FIX] Omnichannel session monitor is not starting (#18412)
  [FIX] Invalid MIME type when uploading audio files (#18426)
  [FIX] Error when updating omnichannel department without agents parameter (#18428)
  [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446)
  [FIX] Multiple push notifications sent via native drivers (#18442)
  [FIX] Appending 'false' to Jitsi URL (#18430)
@nixxou nixxou mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @rodrigok