GIVCAMP-282 | React Player preview (light) #216
Conversation
✅ Deploy Preview for giving-campaign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* dev: (34 commits) GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256) 1.3.3 Update robots to use different URL for sitemap path (#254) 1.3.2 GIVCAMP-307 | Stacked story hero variant (#251) 1.3.1 GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248) Bump follow-redirects from 1.15.4 to 1.15.6 (#249) 1.3.0 GIVCAMP-289: Inline External Script Loading. (#246) GIVCAMP-88 | data card (#245) 1.2.2 GIVCAMP-294 | Basic Hero overlay options and image optimization (#243) HSTS set max-age to 31536000 (#242) 1.2.1 Icon animation (#240) GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239) 1.2.0 GIVCAMP-293 | Moment poster (#236) NoJira: Remove Editor Token (#237) ...
yvonnetangsu
changed the title
yvonnetangsu
changed the title
| // This previewAriaLabel prop is not documented but it is in the React Player source code | ||
| previewAriaLabel={isPreview ? previewAriaLabel : undefined} |
There was a problem hiding this comment.
SODA said this makes it ok accessible (it renders a clickable/focusable div). When I have time I'll open a PR to React Player to add a role="button" (SODA suggestion to make it fully accessible).
There was a problem hiding this comment.
You can always just log a request or file a bug. It is nice of you to submit the PR but sometimes you can just let others know if you don't have the time.
| @@ -40,7 +40,7 @@ | |||
| "framer-motion": "^10.16.4", | |||
| "next": "13.4.9", | |||
| "react-loading-skeleton": "^3.3.1", | |||
| "react-player": "^2.14.1", | |||
| "react-player": "^2.15.1", | |||
There was a problem hiding this comment.
Update react player to latest which included this new previewAriaLabel prop
| className="lg:col-span-6 bg-black-70" | ||
| aspectRatio="16x9" | ||
| previewAriaLabel={previewAriaLabel} |
There was a problem hiding this comment.
Yay reading through the code...
When things are not in the doxn it scares me a bit for if the maintainers are going to continue to maintain the prop. Most of the time it is just because they haven't gotten to the documentation yet and I don't see this as a critical thing but I thought I would share my $0.02 anyhow.
There was a problem hiding this comment.
Yeah, it looks like they recently switched maintainer. I looked at the merged pull request, and looks like this prop was added fairly recently:
cookpete/react-player#1705
I'll give them benefit of the doubt this time 😆
|
This is looking and working just fine but I noticed that the double quotes are there. Looks like unicode FTW here. |
Thanks for checking @sherakama ! 😄 |
* dev: 1.3.5 GIVCAMP-282 | React Player preview (light) (#216)
* dev: 1.4.0 GIVCAMP-313 | Vertical poster component with parallax (#253) 1.3.5 GIVCAMP-282 | React Player preview (light) (#216) 1.3.4 Update sitemap.ts (#257) # Conflicts: # components/Parallax/Parallax.tsx
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Associated Issues and/or People